notes/obsidian: remove default dir-value#545
Merged
NotAShelf merged 3 commits intoNotAShelf:mainfrom Jan 10, 2025
Merged
Conversation
IldenH
approved these changes
Jan 10, 2025
NotAShelf
reviewed
Jan 10, 2025
NotAShelf
reviewed
Jan 10, 2025
Owner
NotAShelf
left a comment
NotAShelf
left a comment
There was a problem hiding this comment.
LGTM. One small suggestion, but it's not strictly necessary.
Please do add an entry to the changelog before I can merge this.
Contributor
Author
Added to changelog, hopefully written correctly |
NotAShelf
reviewed
Jan 10, 2025
| default = "~/my-vault"; | ||
| type = nullOr str; | ||
| example = "~/my-vault"; | ||
| default = null; |
Owner
There was a problem hiding this comment.
Does obsidian.nvim handle this properly?
Contributor
Author
There was a problem hiding this comment.
Does
obsidian.nvimhandle this properly?
Yes, from my testing, although i accidentally commited it. Reverting it, as the other option seems better
LilleAila
force-pushed
the
obsidian-remove-dir-default
branch
from
2ab93dc to
6852120
Compare
Owner
|
Merging once CI passes. |
Owner
|
thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the
obsidian.nvimreadme describes, thediroption is provided for backwards compatibility. The problem with this is that becausenvfdefines this value (with a default value), means that it overrides theworkspacesoption, making it impossible to use. Removing it would keep the same functionality, just without the default.