various: address diniamo's review comments#546
Merged
Conversation
NotAShelf
force-pushed
the
diniamo-moment
branch
2 times, most recently
from
66074fa to
f95ef9c
Compare
diniamo
suggested changes
Jan 10, 2025
NotAShelf
force-pushed
the
diniamo-moment
branch
from
f95ef9c to
ab3a68f
Compare
Owner
Author
|
Hey the preview CI works, good to know. |
diniamo
approved these changes
Jan 10, 2025
|
✅ Preview has been deleted successfully! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And some other fixes. Not necessarily proud of the spellcheck one, but it beats taking an unchecked string.