snippets/luasnip: add setupOpts #549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixed a bug where the plugin previously would not get loaded, as lazy was set to true without a trigger event.
NotAShelf
previously approved these changes
Jan 11, 2025
diniamo
suggested changes
Jan 11, 2025
diniamo
suggested changes
Jan 12, 2025
Contributor
diniamo
left a comment
diniamo
left a comment
There was a problem hiding this comment.
There else seem to be conflicts
diniamo
previously approved these changes
Jan 12, 2025
Contributor
|
-.- |
Contributor
|
@NotAShelf preview action fail, seems to be unrelated |
diniamo
approved these changes
Jan 12, 2025
Owner
|
I'm aware, refer to my comment on Discord for the CI. Can't review for the next 10 hours or so, feel free to merge if you feel it's ready. |
Contributor
|
Can't merge without your review apparently |
NotAShelf
approved these changes
Jan 12, 2025
Owner
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added setupOpts to
vim.snippets.luasnip.Right now, there is a soft dependency on nvim-cmp, because setting
lazy = true, makes it so that it won't load if nvim-cmp is not present and configured. I will not fix that in this pr, as users can setvim.lazy.plugins.luasnip.event = "BufEnter"themselves.