languages/ruby: add ruby support #556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotAShelf
requested changes
Jan 13, 2025
Owner
NotAShelf
left a comment
NotAShelf
left a comment
There was a problem hiding this comment.
Mostly LGTM. A few minor changes for the sake of consistency, and I can merge this.
sodagunz
force-pushed
the
feat-languages-ruby
branch
from
37b8f34 to
149d68b
Compare
NotAShelf
approved these changes
Jan 13, 2025
Owner
|
Merging once CI passes. |
Owner
|
Alright preview CI is unrelated, thank you for your efforts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby is a pain, but I think some basic support is better than nothing and can be improved on.
At the moment, formatters only work if .rubocop.yml contains no extensions, as most of those are not available through nixpkgs yet.
This is my first nix PR so please be thorough.
Sanity Checking
nix fmt).#nix(default package).#maximal.#docs-html(manual, must build)x86_64-linuxaarch64-linuxx86_64-darwinaarch64-darwinAdd a 👍 reaction to pull requests you find important.