Skip to content

languages/python: add ruff formatter #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
NotAShelf merged 4 commits into from
Jan 15, 2025
Merged

languages/python: add ruff formatter #560

NotAShelf merged 4 commits into from
Jan 15, 2025

Conversation

@thamenato
Copy link
Contributor

@thamenato thamenato commented Jan 15, 2025

This PR adds support to using ruff as a formatter for Python.

@thamenato thamenato requested a review from NotAShelf as a code owner January 15, 2025 02:49
NotAShelf
NotAShelf previously approved these changes Jan 15, 2025
View reviewed changes
@NotAShelf
Copy link
Owner

NotAShelf commented Jan 15, 2025

Merging once CI passes.

@NotAShelf
Copy link
Owner

NotAShelf commented Jan 15, 2025

The formatting CI is failing, please run nix fmt or manually format with alejandra.

Also, it'd be nice if you could add a changelog entry.

@thamenato
Copy link
Contributor Author

thamenato commented Jan 15, 2025 •
edited
Loading

The formatting CI is failing, please run nix fmt or manually format with alejandra.

Also, it'd be nice if you could add a changelog entry.

@NotAShelf - I had alejandra running by default and it changed a lot more lines than just the ones I've added. Would that be ok? nvm, it was running nixfmt, all good now.

Will add a changelog entry as well!

NotAShelf
NotAShelf approved these changes Jan 15, 2025
View reviewed changes
Copy link
Owner

@NotAShelf NotAShelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@NotAShelf NotAShelf merged commit 45a6d9b into NotAShelf:main Jan 15, 2025
12 of 13 checks passed
@thamenato thamenato deleted the feat/python-ruff-format branch January 15, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NotAShelf NotAShelf NotAShelf approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thamenato @NotAShelf