Skip to content

feat: add nord theme#563

Merged
NotAShelf merged 1 commit intoNotAShelf:mainfrom
sodagunz:feat-theme-nord
Jan 17, 2025
Merged

feat: add nord theme#563
NotAShelf merged 1 commit intoNotAShelf:mainfrom
sodagunz:feat-theme-nord

Conversation

@sodagunz
Copy link
Contributor

@sodagunz sodagunz commented Jan 17, 2025

For Issue #557

Sanity Checking

  • I have updated the changelog as per my changes
  • I have tested, and self-reviewed my code
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt)
    • My code conforms to the editorconfig configuration of the project
    • My changes are consistent with the rest of the codebase
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual
    • (For breaking changes) I have included a migration guide
  • Package(s) built:
    • .#nix (default package)
    • .#maximal
    • .#docs-html (manual, must build)
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Fixes #557

added nord theme from github.com/gbprod/nord.nvim
fixed a typo
@sodagunz sodagunz marked this pull request as ready for review January 17, 2025 17:56
@sodagunz sodagunz requested a review from NotAShelf as a code owner January 17, 2025 17:56
setup = {transparent ? false, ...}: ''
require("nord").setup({
transparent = ${boolToString transparent},
search = "vscode", -- [vim|vscode]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason we're using vscode here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the style, but honestly the difference is very subtle and we could do without it.

Here's the difference it makes in code.

It basically just changes the color of the first letter as far as I can tell:
image
Left is vim (default), right is vscode.

Copy link
Owner

@NotAShelf NotAShelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NotAShelf
Copy link
Owner

Merging once CI passes.

@NotAShelf NotAShelf merged commit ba27d85 into NotAShelf:main Jan 17, 2025
12 of 13 checks passed
@NotAShelf
Copy link
Owner

Thank you :)

@sodagunz sodagunz deleted the feat-theme-nord branch January 17, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add nord colorscheme

2 participants