Merged
Conversation
NotAShelf
requested changes
Jan 19, 2025
modules/neovim/init/highlight.nix
Outdated
| mkOption { | ||
| type = nullOr bool; | ||
| default = null; | ||
| description = ''Whether to enable ${name}''; |
Owner
There was a problem hiding this comment.
Suggested change
| description = ''Whether to enable ${name}''; | |
| description = "Whether to enable ${name}"; |
Also move example between default and description please.
modules/neovim/init/highlight.nix
Outdated
| ) | ||
| cfg; | ||
| in | ||
| entryAnywhere (concatStringsSep "\n" highlights); |
Owner
There was a problem hiding this comment.
entryAnywhere should be fine, but we might benefit more from placing this before plugin setup since some of them might actually use the highlights set in this module.
NotAShelf
reviewed
Jan 19, 2025
Comment on lines
+14
to
+30
| mkColorOption = target: | ||
| mkOption { | ||
| type = nullOr hexColor; | ||
| default = null; | ||
| example = "#ebdbb2"; | ||
| description = '' | ||
| The ${target} color to use. Written as color name or hex "#RRGGBB". | ||
| ''; | ||
| }; | ||
|
|
||
| mkBoolOption = name: | ||
| mkOption { | ||
| type = nullOr bool; | ||
| default = null; | ||
| example = false; | ||
| description = "Whether to enable ${name}"; | ||
| }; |
Owner
There was a problem hiding this comment.
Not a blocker, but these may be better suited for the extended lib.
NotAShelf
requested changes
Jan 19, 2025
NotAShelf
previously approved these changes
Jan 23, 2025
Owner
|
If you can fix the conflicts, I can merge this. |
NotAShelf
approved these changes
Jan 23, 2025
Owner
|
Thank you :) |
|
✅ Preview has been deleted successfully! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates options for configuring highlight groups, mirroring the options available in
nvim_set_hl.