Skip to content

languages/nix: add nixd#604

Merged
NotAShelf merged 1 commit intoNotAShelf:mainfrom
nezia1:add-nixd
Feb 6, 2025
Merged

languages/nix: add nixd#604
NotAShelf merged 1 commit intoNotAShelf:mainfrom
nezia1:add-nixd

Conversation

@nezia1
Copy link
Contributor

@nezia1 nezia1 commented Feb 6, 2025

This PR introduces a new language server for nix, nixd.

Sanity Checking

  • I have updated the changelog as per my changes
  • I have tested, and self-reviewed my code
  • My changes fit guidelines found in hacking nvf
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt)
    • My code conforms to the editorconfig configuration of the project
    • My changes are consistent with the rest of the codebase
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual
    • (For breaking changes) I have included a migration guide
  • Package(s) built:
    • .#nix (default package)
    • .#maximal
    • .#docs-html (manual, must build)
    • .#docs-linkcheck (optional, please build if adding links)
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add a 👍 reaction to pull requests you find important.

@nezia1 nezia1 requested a review from NotAShelf as a code owner February 6, 2025 12:20
@NotAShelf
Copy link
Owner

You don't need to target v0.7, it has been merged a while ago.

@NotAShelf NotAShelf changed the base branch from v0.7 to main February 6, 2025 12:22
This adds the [nixd](https://github.com/nix-community/nixd) language
server.
github-actions bot pushed a commit that referenced this pull request Feb 6, 2025
@github-actions
Copy link

github-actions bot commented Feb 6, 2025

🚀 Live preview deployed from ff31e0f

View it here:

Debug Information

Triggered by: NotAShelf

HEAD at: add-nixd

Reruns: 188

@NotAShelf
Copy link
Owner

Merging once the CI pass, hoping you have performed some self-tests.

@nezia1
Copy link
Contributor Author

nezia1 commented Feb 6, 2025

Merging once the CI pass, hoping you have performed some self-tests.

The language server did work correctly when running it on the nvf codebase, as well as resolved module options/packages.

@NotAShelf NotAShelf merged commit ff31e0f into NotAShelf:main Feb 6, 2025
13 checks passed
@github-actions
Copy link

github-actions bot commented Feb 6, 2025

✅ Preview has been deleted successfully!

github-actions bot pushed a commit that referenced this pull request Feb 6, 2025
@nezia1 nezia1 deleted the add-nixd branch February 6, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants