languages/markdown: Add markview renderer#702
Conversation
|
I think it's better to remove the assert, it doesnt break anything (just results in a bad formatting) |
1f20c9a to
c10c389
Compare
NotAShelf
left a comment
There was a problem hiding this comment.
Mostly LGTM, might be worth linking the plugin in the changelog like we do for other plugins. Also left a review comment.
I'm unsure if this belongs to the markdown language module. The description itself states it's a "markdown, Typst, latex, html(inline) & YAML previewer." Maybe make it a standalone plugin, and enable it inside the markdown language module tired to the toggle?
Maybe, but it specializes in markdown mostly. If i remember correctly, the defaults are for markdown only too. |
02ee4cc to
bc978c4
Compare
|
@BANanaD3V do you think you could resolve the merge conflicts. I think it could merged afterwards. |
Done |
|
I'll just merge this and handle formatting myself, thank you @BANanaD3V |
|
✅ Preview has been deleted successfully! |
Adds markview renderer for markdown. Unsure if i want the assertion or not, but you generally shouldn't have two renderers enabled at the same time.