Skip to content

Comments

languages/markdown: Add markview renderer#702

Merged
NotAShelf merged 2 commits intoNotAShelf:mainfrom
BANanaD3V:main
May 10, 2025
Merged

languages/markdown: Add markview renderer#702
NotAShelf merged 2 commits intoNotAShelf:mainfrom
BANanaD3V:main

Conversation

@BANanaD3V
Copy link
Contributor

Adds markview renderer for markdown. Unsure if i want the assertion or not, but you generally shouldn't have two renderers enabled at the same time.

@BANanaD3V BANanaD3V requested a review from NotAShelf as a code owner March 10, 2025 09:52
github-actions bot pushed a commit that referenced this pull request Mar 10, 2025
@github-actions
Copy link

github-actions bot commented Mar 10, 2025

🚀 Live preview deployed from 4855b54

View it here:

Debug Information

Triggered by: NotAShelf

HEAD at: main

Reruns: 835

@BANanaD3V
Copy link
Contributor Author

I think it's better to remove the assert, it doesnt break anything (just results in a bad formatting)

@BANanaD3V BANanaD3V force-pushed the main branch 2 times, most recently from 1f20c9a to c10c389 Compare March 11, 2025 19:08
github-actions bot pushed a commit that referenced this pull request Mar 11, 2025
Copy link
Owner

@NotAShelf NotAShelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, might be worth linking the plugin in the changelog like we do for other plugins. Also left a review comment.

I'm unsure if this belongs to the markdown language module. The description itself states it's a "markdown, Typst, latex, html(inline) & YAML previewer." Maybe make it a standalone plugin, and enable it inside the markdown language module tired to the toggle?

@BANanaD3V
Copy link
Contributor Author

I'm unsure if this belongs to the markdown language module. The description itself states it's a "markdown, Typst, latex, html(inline) & YAML previewer." Maybe make it a standalone plugin, and enable it inside the markdown language module tired to the toggle?

Maybe, but it specializes in markdown mostly. If i remember correctly, the defaults are for markdown only too.

@NotAShelf NotAShelf force-pushed the main branch 5 times, most recently from 02ee4cc to bc978c4 Compare March 17, 2025 11:42
@NotAShelf
Copy link
Owner

@BANanaD3V do you think you could resolve the merge conflicts. I think it could merged afterwards.

@BANanaD3V
Copy link
Contributor Author

@BANanaD3V do you think you could resolve the merge conflicts. I think it could merged afterwards.

Done

github-actions bot pushed a commit that referenced this pull request May 9, 2025
@NotAShelf
Copy link
Owner

I'll just merge this and handle formatting myself, thank you @BANanaD3V

@NotAShelf NotAShelf merged commit 4855b54 into NotAShelf:main May 10, 2025
11 of 14 checks passed
@github-actions
Copy link

✅ Preview has been deleted successfully!

github-actions bot pushed a commit that referenced this pull request May 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants