Skip to content

Comments

blink: fix unusable cmdline completion#828

Merged
horriblename merged 2 commits intoNotAShelf:mainfrom
horriblename:blink-cmdline
May 26, 2025
Merged

blink: fix unusable cmdline completion#828
horriblename merged 2 commits intoNotAShelf:mainfrom
horriblename:blink-cmdline

Conversation

@horriblename
Copy link
Collaborator

@horriblename horriblename commented Apr 13, 2025

fixes #811

Sanity Checking

  • I have updated the changelog as per my changes
  • I have tested, and self-reviewed my code
  • My changes fit guidelines found in hacking nvf
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt)
    • My code conforms to the editorconfig configuration of the project
    • My changes are consistent with the rest of the codebase
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual
    • (For breaking changes) I have included a migration guide
  • Package(s) built:
    • .#nix (default package)
    • .#maximal
    • .#docs-html (manual, must build)
    • .#docs-linkcheck (optional, please build if adding links)
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add a 👍 reaction to pull requests you find important.

github-actions bot pushed a commit that referenced this pull request Apr 13, 2025
@github-actions
Copy link

github-actions bot commented Apr 13, 2025

🚀 Live preview deployed from b45f051

View it here:

Debug Information

Triggered by: horriblename

HEAD at: blink-cmdline

Reruns: 904

github-actions bot pushed a commit that referenced this pull request Apr 17, 2025
@horriblename
Copy link
Collaborator Author

@mnpqraven if you could take a look and see if the default cmdline keybinds make sense, it would appreciated :)

@horriblename horriblename marked this pull request as ready for review April 22, 2025 18:18
@mnpqraven
Copy link

mnpqraven commented Apr 23, 2025

@mnpqraven if you could take a look and see if the default cmdline keybinds make sense, it would appreciated :)

thanks for the ping, i'm gonna check it out!
as soon as i get the pr build working... I thought it would work if i just change the input url into

    nvf.url = "github:horriblename/nvf";

but i'm getting The option vim.autocomplete.blink-cmp' does not exist. error, not sure why this is the case

mnpqraven added a commit to mnpqraven/dotfiles_nix that referenced this pull request Apr 23, 2025
@horriblename
Copy link
Collaborator Author

nvf.url = "github:horriblename/nvf/blink-cmdline";

missing the branch name at the end

mnpqraven added a commit to mnpqraven/dotfiles_nix that referenced this pull request Apr 23, 2025
@mnpqraven
Copy link

I can confirm cmdline now works ootb with only

{
    blink-cmp.enable = true;
}

mnpqraven added a commit to mnpqraven/dotfiles_nix that referenced this pull request Apr 23, 2025
@mnpqraven
Copy link

i think we should omit the confirm keymap for cmdline, the default <CR> binding to accept the completion will trigger autocomplete in the cmdline when we don't expect them to complete.

example: :q<CR> will be :qall + the buffer stays open because it hasn't exited

@horriblename
Copy link
Collaborator Author

I forgot about this lol

github-actions bot pushed a commit that referenced this pull request May 16, 2025
github-actions bot pushed a commit that referenced this pull request May 26, 2025
@NotAShelf
Copy link
Owner

Is this ready for a merge?

@horriblename
Copy link
Collaborator Author

yep

@horriblename horriblename merged commit b45f051 into NotAShelf:main May 26, 2025
14 checks passed
@github-actions
Copy link

✅ Preview has been deleted successfully!

github-actions bot pushed a commit that referenced this pull request May 26, 2025
mnpqraven added a commit to mnpqraven/dotfiles_nix that referenced this pull request Jun 2, 2025
mnpqraven added a commit to mnpqraven/dotfiles_nix that referenced this pull request Jun 2, 2025
* feat(blink-cmp): minimal config, tracks NotAShelf/nvf#828

* dev

* add back snippets loading

* remove fixes cause upstream updated

* clear commented code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

blink-cmp default's cmdline doesn't work, needs flags to turn on

3 participants