Skip to content

Comments

themes/solarized-osaka: init#899

Merged
NotAShelf merged 4 commits intoNotAShelf:mainfrom
mitokolash:solarized-osaka
May 17, 2025
Merged

themes/solarized-osaka: init#899
NotAShelf merged 4 commits intoNotAShelf:mainfrom
mitokolash:solarized-osaka

Conversation

@mitokolash
Copy link
Contributor

@mitokolash mitokolash commented May 15, 2025

Added solarized-osaka.nvim theme #896

Sanity Checking

  • I have updated the changelog as per my changes
  • I have tested, and self-reviewed my code
  • My changes fit guidelines found in hacking nvf
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt)
    • My code conforms to the editorconfig configuration of the project
    • My changes are consistent with the rest of the codebase
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual
    • (For breaking changes) I have included a migration guide
  • Package(s) built:
    • .#nix (default package)
    • .#maximal
    • .#docs-html (manual, must build)
    • .#docs-linkcheck (optional, please build if adding links)
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add a 👍 reaction to pull requests you find important.

@github-actions
Copy link

github-actions bot commented May 15, 2025

🚀 Live preview deployed from a595233

View it here:

Debug Information

Triggered by: NotAShelf

HEAD at: solarized-osaka

Reruns: 866

@mitokolash mitokolash changed the title Solarized osaka themes/solarized-osaka: init May 15, 2025
Copy link
Collaborator

@Soliprem Soliprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

github-actions bot pushed a commit that referenced this pull request May 16, 2025
@NotAShelf
Copy link
Owner

NotAShelf commented May 17, 2025

The first PR to get all three maintainer approvals I think, wild. Also @horriblename I think we should consider a setupOpts like interface for themes, this is really not maintainable on the long term.

@NotAShelf NotAShelf merged commit a595233 into NotAShelf:main May 17, 2025
14 checks passed
@NotAShelf
Copy link
Owner

Thank you @haskex :)

@github-actions
Copy link

✅ Preview has been deleted successfully!

@NotAShelf NotAShelf mentioned this pull request May 17, 2025
1 task
github-actions bot pushed a commit that referenced this pull request May 17, 2025
@mitokolash mitokolash deleted the solarized-osaka branch May 17, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants