fix: disable Conform for Rust#900
Merged
NotAShelf merged 2 commits intoNotAShelf:mainfrom May 17, 2025
Merged
Conversation
ckoehler
requested review from
NotAShelf,
Soliprem and
horriblename
as code owners
Contributor
Author
|
Ah changelog, standby for that. |
Collaborator
|
don't delete the formatter config, do this instead: nvf/modules/plugins/languages/go.nix Line 90 in 74587e2 |
Contributor
Author
Done. |
Collaborator
|
uh, I meant change the deafult value of the option (+ add defaultText), leave the config section alone b762752#diff-ceba2b90515a5fc940fc0dc9d5677f1c27555c890ecd2677ca854effc05164a6R86-R94 |
NotAShelf
requested changes
May 17, 2025
Owner
NotAShelf
left a comment
NotAShelf
left a comment
There was a problem hiding this comment.
Two quick nits, looks good to merge afterwards.
horriblename
approved these changes
May 17, 2025
Collaborator
|
LGTM thanks! |
NotAShelf
approved these changes
May 17, 2025
|
✅ Preview has been deleted successfully! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think we want Conform to also do autoformatting. I am running into issues where it doesn't respect the
rustfmt.tomlfile and will happily format according to the 2015 edition. The builtinRustFmtcommand also works and can be set up to autosave, butrustaceanvimincludesrust-analyzerwhich will runrustfmtas well.All this to say, autoformatting still works without Conform and also doesn't break stuff.