Merged
Conversation
Collaborator
Author
|
Does not compile right now, but I will get to it later |
RGBCube
force-pushed
the
change-rgbcube-ytsulunonpmv
branch
3 times, most recently
from
50cc87a to
a150200
Compare
NotAShelf
reviewed
May 19, 2025
RGBCube
force-pushed
the
change-rgbcube-ytsulunonpmv
branch
3 times, most recently
from
e51ad0c to
1fe3ca3
Compare
faukah
requested changes
Jun 12, 2025
Collaborator
Author
|
Depends on #37. Merge that then merge this. (Rebase it actually) |
Collaborator
|
Should we squash this? |
Collaborator
Author
|
No squashing |
Owner
|
Remove the CullOS advert, I'm not advertising your project in mine. You can remove the rustfmt config if that's a dealbreaker, and I'll add my own at a later date. |
faukah
reviewed
Jun 13, 2025
| let start = Instant::now(); | ||
| let is_desktop = self.is_desktop()?; | ||
| log::debug!( | ||
| "checked if is a desktop in {millis}ms", |
Collaborator
There was a problem hiding this comment.
Clearer debug logs would be nice here.
Checked if system is a desktop or something like that.
Co-authored-by: bloxx12 <charlie@charlieroot.dev>
NotAShelf
approved these changes
Jun 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.