-
Notifications
You must be signed in to change notification settings - Fork 153
Adding Crow, Missed Enchants, partial Bestiary, and more #2223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Fixed Turbo Wheat being outdated - Fixed Ender Slayer 6 having the wrong percentage - Fixed Aqua Affinity still claiming to be obtained from Prismarine Collection - Fixed Chyme, Sewer Fish, and Gift of Learning having outdated lore - Added Smooth Red Sandstone to Jade support for Umber
pull to garden
also adding greenhouse blueprint and supplying new cactus green recipe
just a few things that seem to have been missed. I'll do a rewrite of the skymart file at some point.
forgot to include Crop Fever
|
I've detected some problems you might want to take a look at, you can see them as annotations in the files tab. |
jani270
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks already, just the comments
Also could you add parents for the pet and enchants that you added?
- Added parents for Crow Pet, Turbo-Rose/Moonflower/Sunflower, and Crop Fever. - Added back in old Enchanted Cactus Green recipe. - Added Firefly Pest bestiary and Loot Table
|
I've detected some problems you might want to take a look at, you can see them as annotations in the files tab. |
|
I've detected some problems you might want to take a look at, you can see them as annotations in the files tab. |
jani270
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also there is a ingame command to refresh the nbt, you dont have to update it manually /firm dev reexportlore id
|
I've detected some problems you might want to take a look at, you can see them as annotations in the files tab. |
|
unrelated but you really shouldnt be making prs from the master branch |
|
I've detected some problems you might want to take a look at, you can see them as annotations in the files tab. |
jani270
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to fix the gh actions, otherwise looks good
|
I've detected some problems you might want to take a look at, you can see them as annotations in the files tab. |
I also reverted sacks because you guys didn't like it
|
I've detected some problems you might want to take a look at, you can see them as annotations in the files tab. |
|
I've detected some problems you might want to take a look at, you can see them as annotations in the files tab. |
yeah, I'm still learning how to use github as I've never used one of these sites collectively until about a month ago and before hand was kinda just dumping everything without actually paying attention. In the future, yeah, I will start properly using branches and actually paying more attention to what I'm doing |
|
I've detected some problems you might want to take a look at, you can see them as annotations in the files tab. |
jani270
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
I swear I did those already lmao did I not press save |
|
I've detected some problems you might want to take a look at, you can see them as annotations in the files tab. |
nope |
jani270
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did the needed changes myself, hope thats fine for you!
|
Yeah that's fine lol I haven't had proper access to a PC the last two days, have had the power out and my brain has been on fire (possibly literally as I'm debating if I need to go to the hospital) |

I will get to the rest of new pest bestiary eventually, as well as rewrite the
constants/skymartfile eventually. tbh, not sure what it's used for