Bump AsyncKeyedLock to 8.0.2, clean up lock.#12
Open
MarkCiliaVincenti wants to merge 3 commits intoNotOfficer:masterfrom
Open
Bump AsyncKeyedLock to 8.0.2, clean up lock.#12MarkCiliaVincenti wants to merge 3 commits intoNotOfficer:masterfrom
MarkCiliaVincenti wants to merge 3 commits intoNotOfficer:masterfrom
Conversation
MarkCiliaVincenti
changed the title
Updated AsyncKeyedLock package version from 8.0.0 to 8.0.2.
MarkCiliaVincenti
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also wanted to comment on how the locker options may be suboptimal, especially that PoolInitialFill value. 64 means you are sure you will have a minimum of 64 concurrent threads with distinct FGuid values, so you want to create them immediately on startup so they're already allocated.
The standard settings I like working with (also set as the default values) are 20 for the pool size and 1 for the pool initial fill. Please note that the 20 doesn't mean a hard rate limit of 20 concurrent threads. If a 21st one comes along, the pool would be empty and a SemaphoreSlim object is created just as if there was no pooling involved.