Profile: add back in the return types now we have 7.1 ...#137
Merged
roberthunt merged 2 commits intomasterfrom May 9, 2017
Merged
Profile: add back in the return types now we have 7.1 ...#137roberthunt merged 2 commits intomasterfrom
roberthunt merged 2 commits intomasterfrom
Conversation
…ome arguments to the create nullable I think the change to profile manager are needed as a result of the new ConvertEmptyStringsToNull middleware
roberthunt
approved these changes
May 9, 2017
Contributor
roberthunt
left a comment
roberthunt
left a comment
There was a problem hiding this comment.
Looks fine, I've added in some missing return types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and make some arguments to the ProfileManager::create nullable
I think the change to profile manager are needed as a result of the new ConvertEmptyStringsToNull middleware