Skip to content

JS: need to server the manifest file when using extract#138

Merged
roberthunt merged 5 commits intomasterfrom
js-mainfest
May 12, 2017
Merged

JS: need to server the manifest file when using extract#138
roberthunt merged 5 commits intomasterfrom
js-mainfest

Conversation

@dpslwk
Copy link
Member

@dpslwk dpslwk commented May 9, 2017

@dpslwk dpslwk requested a review from roberthunt May 9, 2017 01:01
@dpslwk dpslwk added the front end Frontend, Blade, CSS, JS or text copy label May 9, 2017
@dpslwk dpslwk added this to the Base System milestone May 9, 2017
@dpslwk
Copy link
Member Author

dpslwk commented May 9, 2017

Foundation is still broken mind, there seems to be some big issue with jQuery, foundation and Laravel Mix

think we may need to update the .js files as per the last post on this issue
laravel-mix/laravel-mix#229
but there is also this massive issue I've not yet ready thought, though the last comment suggest somethings might change for the better with foundation 6.4
foundation/foundation-sites#7386

@mathw
Copy link
Contributor

mathw commented May 9, 2017

This is quite frustrating, because I spent ages getting it working before - was this triggered by the Laravel update?

@roberthunt
Copy link
Contributor

roberthunt commented May 9, 2017

@matw yes, with Laravel 5.4 they introduced "Laravel Mix" which is a successor to "Laravel Elixer" and is a wrapper around Webpack rather than Gulp. You can freely edit the webpack.config.js though if you need to do more advanced stuff.

There is a useful blog post about the changes here: https://mattstauffer.co/blog/introducing-laravel-mix-new-in-laravel-5-4

Or at least not throwing an error in my browser console
@dpslwk
Copy link
Member Author

dpslwk commented May 9, 2017

@roberthunt @mathw quick an dirty fix but will do till we get our hands on 6.4
its not like we will be live before then

@roberthunt roberthunt merged commit 3f384d4 into master May 12, 2017
@dpslwk dpslwk deleted the js-mainfest branch May 12, 2017 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug front end Frontend, Blade, CSS, JS or text copy

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants