Merged
Conversation
then exclude them from future diff by adding to the migrations config
roberthunt
approved these changes
May 12, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now we have updated to 5.4 I've pulled in Passport in order to use it with some JS front end stuff
Its all working nicely with laravel-doctrine thanks to the recent PR in passport
Had to recreate the default laravel migrations in laravel-doctrine/migrations form and the have them excluded from future
php artisan doctinre:migrations:diffcommand, this need the migrations config to be re published.We are all setup for use with JS and axios as per
https://laravel.com/docs/5.4/passport#consuming-your-api-with-javascript
might need to add the following to app.js for ajax
but my next steps will test that
Will likely need to revisit passport frontend stuff (https://laravel.com/docs/5.4/passport#frontend-quickstart) in the future when I look at hooking it up with discourse and lighting-automation but thats well past base system miles stone needs