Fix a bunch of bugs/minor bits picked up by scrutinizer

app/Console/Commands/Permissions/BaseCommand.php

@@ -67,7 +67,7 @@ protected function printError($message, $error)
      */
     protected function getRole($name, $error = true)
     {
-        $role = $this->roleRepository->findOneBy(['name' => $name]);
+        $role = $this->roleRepository->findOneByName($name);
         if ( ! is_null($role)) {
             return $role;
         } else {

app/HMS/Entities/Email.php

@@ -152,7 +152,7 @@ public function getSentAt(): Carbon
     /**
      * Sets the value of sentAt.
      *
-     * @param string $sentAt the sent at
+     * @param Carbon $sentAt the sent at
      *
      * @return self
      */

app/HMS/Entities/User.php

@@ -267,7 +267,7 @@ public function getKey()
     /**
      * Sets the value of firstname.
      *
-     * @param string $name the name
+     * @param string $firstname the name
      *
      * @return self
      */

app/HMS/Repositories/Doctrine/DoctrineRoleRepository.php

@@ -33,7 +33,7 @@ public function findAll()
      */
     public function findOneByName(string $roleName)
     {
-        return parent::findOneBy(['name' => $roleName]);
+        return parent::findOneByName($roleName);
     }
 
     /**

app/HMS/User/Permissions/RoleManager.php

@@ -106,7 +106,10 @@ public function addUserToRole(User $user, Role $role)
      */
     public function addUserToRoleByName(User $user, string $roleName)
     {
-        $role = $this->roleRepository->findOneByName($roleName);
+        if ( ! $role = $this->roleRepository->findOneByName($roleName)) {
+            return;
+        }
+
         $this->addUserToRole($user, $role);
     }
 
@@ -130,7 +133,10 @@ public function removeUserFromRole(User $user, Role $role)
      */
     public function removeUserFromRoleByName(User $user, string $roleName)
     {
-        $role = $this->roleRepository->findOneByName($roleName);
+        if ( ! $role = $this->roleRepository->findOneByName($roleName)) {
+            return;
+        }
+
         $this->removeUserFromRole($user, $role);
     }
 }

app/Listeners/ViMbAdminSubscriber.php

@@ -85,7 +85,7 @@ public function onUserAddedToRole(UserAddedToRole $event)
             $alias->addForwardAddress($event->user->getEmail());
 
             // save the updated alias back to the external API
-            $this->client->updateAlias($alias);
+            $response = $this->client->updateAlias($alias);
             if ( ! $response instanceof Link) {
                 throw new Exception('Alias update failed with Error: '.$response);
             }