fix: Implement /resume slash command (Issue #2869)#2893
Open
ten-jampa wants to merge 1 commit intoNousResearch:mainfrom
Open
fix: Implement /resume slash command (Issue #2869)#2893ten-jampa wants to merge 1 commit intoNousResearch:mainfrom
ten-jampa wants to merge 1 commit intoNousResearch:mainfrom
Conversation
Issue NousResearch#2869: Session history not persisting between restarts Root cause: The /resume command was registered but not implemented as a slash command - only worked via --resume CLI flag. Changes: 1. Add /resume slash command handler in cli.py - Lists available sessions when used without args - Resumes specified session and loads history from DB 2. Improve /history command - Loads history from database if not in current session - Shows saved sessions when no history available 3. Fix NoneType crash in session listing - Handle explicitly null title to prevent 'NoneType is not subscriptable'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Issue #2869: Session history not persisting between restarts
Problem
When Hermes was closed and reopened, showed empty and showed "Unknown command" - session history was not persisting between restarts.
Root Cause
The command was registered in the command registry but not implemented as a slash command handler - it only worked via the CLI flag when starting Hermes.
Solution
Add slash command handler in :
Improve command:
Fix NoneType crash:
Testing
Files Changed