Fix SingleBlockModifier applying to all blocks of the same base type in certain circumstances #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This ensures future retrieval of the BlockInformation at the position already has the modifier as an available block Related NovaEngineering-Source#144
This reverts commit 2269792. - Adding the modifier to the pattern directly caused issues with auto-assembly requirements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #144. You can see the issue for more details, but in summary:
SingleBlockModifierReplacementdeclared would be allowed in any position where the base block was (after certain rendering).BlockArray.BlockInformation.This PR fixes the issue by
directly adding the modifier to the machine's pattern on deserialization/reloadcopying theBlockInformationsaved in the pattern before adding the modifier's blockstate. Note this is needed so we don't modify the canonical instance shared by other block positions.