[train][Fix] Fix process group creation with vLLM for run_engines_locally=false
#789
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes process group creation with vLLM for
run_engines_locally=false. Currently, weight syncing withrun_engines_locallyis broken, and the remote engine example https://github.com/NovaSky-AI/SkyRL/blob/main/skyrl-train/examples/remote_inference_engine/run_remote.sh fails withNCCL error : invalid argumentThis is because of our custom process group creation logic - I suspect this broke after a PyTorch upgrade. It is recommended to use vLLM's StatelessProcessGroup abstraction for creating multiple process groups without polluting global state.
This PR only modifies the vLLM + NCCL backend codepath to use the new process group creation logic. Fixes for Sglang will follow in a follow-up PR