Skip to content

Commit c9a98be

Browse files
committed
UserHighlighterSimple: don't highlight mainspace articles starting with "User" as users
1 parent a6f8b3d commit c9a98be

File tree

2 files changed

+16
-1
lines changed

2 files changed

+16
-1
lines changed

UserHighlighterSimple/modules/UserHighlighterSimple.js

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,14 @@ export class UserHighlighterSimple {
141141
}
142142

143143
// Skip links that aren't to user pages
144-
const isUserPageLink = url.includes( '/w/index.php?title=User' ) || url.includes( '/wiki/User' );
144+
const isUserPageLink = url.includes( '/w/index.php?title=User:' ) ||
145+
url.includes( '/w/index.php?title=User_talk:' ) ||
146+
url.includes( '/w/index.php?title=User%20talk:' ) ||
147+
url.includes( '/w/index.php?title=User talk:' ) ||
148+
url.includes( '/wiki/User:' ) ||
149+
url.includes( '/wiki/User_talk:' ) ||
150+
url.includes( '/wiki/User%talk:' ) ||
151+
url.includes( '/wiki/User talk:' );
145152
if ( !isUserPageLink ) {
146153
return false;
147154
}

UserHighlighterSimple/tests/UserHighlighterSimple.test.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,14 @@ describe( 'linksToAUser( url )', () => {
7777
expect( userHighlighterSimple.linksToAUser( 'https://a:a' ) ).toBe( false );
7878
expect( userHighlighterSimple.linksToAUser( 'http://Wikipedia:Requests%20for%20arbitration/Eastern%20Europe' ) ).toBe( false );
7979
} );
80+
81+
test( 'mainspace article names that start with "User"', () => {
82+
expect( userHighlighterSimple.linksToAUser( 'https://en.wikipedia.org/wiki/User' ) ).toBe( false );
83+
expect( userHighlighterSimple.linksToAUser( 'https://en.wikipedia.org/wiki/User_(computing)' ) ).toBe( false );
84+
expect( userHighlighterSimple.linksToAUser( 'https://en.wikipedia.org/wiki/User-centered_design' ) ).toBe( false );
85+
expect( userHighlighterSimple.linksToAUser( 'https://en.wikipedia.org/wiki/User_interface' ) ).toBe( false );
86+
} );
87+
8088
} );
8189

8290
describe( 'getTitle( url )', () => {

0 commit comments

Comments
 (0)