Skip to content

fix: add cleanup step for pkgdown pull request workflow#49

Merged
akselthomsen merged 2 commits intomainfrom
fix/pkgdown-cleanup
Jan 14, 2026
Merged

fix: add cleanup step for pkgdown pull request workflow#49
akselthomsen merged 2 commits intomainfrom
fix/pkgdown-cleanup

Conversation

@akselthomsen
Copy link
Member

@akselthomsen akselthomsen commented Jan 14, 2026

Summary

Add step to restore original checkout for cleanup in PRs due to the post job cleanup being confused
when the workflow is running for a PR. The culprit here is the checkout of the gh-pages branch, and seems to only be a problem for packages with a custom setup action such as whirl.

Failing run on whirl:
https://github.com/NovoNordisk-OpenSource/whirl/actions/runs/20995252298/job/60350301124

New successful run using this branch:
https://github.com/NovoNordisk-OpenSource/whirl/actions/runs/20996573128/job/60354827527

Changes Made

  • Added checkout step again.

Testing

  • Everything passes and use tested in whirl above.

Checklist

  • Code changes have been tested
  • Documentation has been updated, if applicable
  • All automated tests pass
  • Coding style and naming conventions have been followed
  • The PR is ready for review and merge

Add step to restore original checkout for cleanup in PRs.

Signed-off-by: Aksel Thomsen <thomsenaksel@gmail.com>
Signed-off-by: Aksel Thomsen <thomsenaksel@gmail.com>
@github-actions
Copy link

Code coverage

Name Coverage (%)
r.workflows 100
R/hello.R 100

@github-actions
Copy link

Github pages

Review the pkgdown webpage for the PR here

@akselthomsen akselthomsen marked this pull request as ready for review January 14, 2026 14:07
@akselthomsen akselthomsen added the bug Something isn't working label Jan 14, 2026
@vladimirobucina vladimirobucina self-requested a review January 14, 2026 14:44
Copy link

@vladimirobucina vladimirobucina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it works, it works!

@akselthomsen akselthomsen merged commit 5db83f4 into main Jan 14, 2026
15 checks passed
@akselthomsen akselthomsen deleted the fix/pkgdown-cleanup branch January 14, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants