Fix build errors for aarch64-unknown-linux-gnu#299
Open
addiesh wants to merge 1 commit intoNoxime:masterfrom
Open
Fix build errors for aarch64-unknown-linux-gnu#299addiesh wants to merge 1 commit intoNoxime:masterfrom
aarch64-unknown-linux-gnu#299addiesh wants to merge 1 commit intoNoxime:masterfrom
Conversation
Collaborator
|
While I like the idea of properly supporting aarch64 as a platform, I'd like for this to be addressed in CI to ensure it doesn't break once we do start supporting it. |
|
At the moment, there's no way to have ARM runners on GitHub without paying. |
As of one month ago this is no longer true: https://github.blog/changelog/2026-01-29-arm64-standard-runners-are-now-available-in-private-repositories/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the steamworks-rs code uses u8/i8 where it should use c_char. This was quick-and-dirty patch job to get it building on arm64. I don't actually have an arm machine on-hand to test it natively, but it does compile. 👍