-
Notifications
You must be signed in to change notification settings - Fork 737
Update NuGetCommands commands in XPlat to debug mode only #6906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
martinrrm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting... I wasn't aware that we needed to add the register if we wanted to debug the update command, thanks you potentially saved us time for future development.
Also, consider updating the title to say UpdateCommand only, I thought this was for all.
I agree with the suggestion to update the title to explain which command is being addressed. |
Thanks for the note! I used |
e693172
Bug
Fixes: #6804 (comment)
Description
Update XPlat debug commands to be registered only during DEBUG builds.
NuGetCommandsclass is used by the .NET SDK CLI to register NuGet commands. https://github.com/NuGet/NuGet.Client/blob/dev/src/NuGet.Core/NuGet.CommandLine.XPlat/NuGetCommands.csNuGet.CommandLine.XPlatentry point.PR Checklist