Kafka Adapter #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extended the event module to support Kafka as an alternative to socket-based event handling. Added initialization, publish, and subscribe logic for Kafka, allowing events to be sent and received via Kafka topics. Refactored type definitions and updated method signatures to support both socket and Kafka backends.
Refactored event client to support both in-memory (socket.io) and Kafka backends. Added type-safe initialization options, async publish/subscribe methods, and error handling for Kafka. Introduced docker-compose for local Kafka setup and provided a Kafka usage example. Removed Jest config and legacy tests to focus on integration-based workflows.
Refactored the event system to maintain persistent Kafka producer and per-topic consumers, improving connection reuse and error handling. Added an async cleanup method to gracefully disconnect all resources, and process signal handlers for shutdown. Updated API to make init, publish, subscribe, and cleanup methods asynchronous for better reliability.
Reorganized event handling logic by introducing EventAdapter interface and splitting in-memory and Kafka implementations into separate adapter classes. This improves modularity and maintainability, allowing easier extension for new event backends. The Event.ts file now delegates to the appropriate adapter based on initialization options.
Moved event adapter interfaces and implementations into a new 'adapters' directory. The event system now delegates to either InMemoryAdapter or KafkaAdapter via a unified EventAdapter interface, improving modularity and separation of concerns. Updated type imports and removed socket and kafka logic from Event.js, delegating all transport-specific logic to adapters.
canmingir
approved these changes
Aug 28, 2025
canmingir
approved these changes
Aug 28, 2025
Introduced a 'test' script to package.json that runs Jest on the src directory for easier testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.