Enable custom HDR luminance via INI and env var#528
Open
christopher-conley wants to merge 1 commit intoNukem9:masterfrom
Open
Enable custom HDR luminance via INI and env var#528christopher-conley wants to merge 1 commit intoNukem9:masterfrom
christopher-conley wants to merge 1 commit intoNukem9:masterfrom
Conversation
This enables the user to manually specify min/max HDR luminance settings instead of what's returned from DXGI query or the hardcoded default values. Adds EnableHDRLuminanceOverride, HDRLuminanceMin, and HDRLuminanceMax as environment variables and INI settings. Also adds an overload for Util::GetSetting which returns a float value to read HDRLuminanceMin and HDRLuminanceMax. FFFrameInterpolator::QueryHDRLuminanceRange is modified to check if the user has overridden the default hardcoded values via env var or INI setting and prefers to use those values first if EnableHDRLuminanceOverride is true and a custom value has been provided.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables the user to manually specify min/max HDR luminance settings instead of what's returned from DXGI query or the hardcoded default values.
Adds the following as environment variables and INI settings:
EnableHDRLuminanceOverride (bool)HDRLuminanceMin (float)HDRLuminanceMax (float)Also adds an overload for
Util::GetSettingwhich returns a float value to read intoHDRLuminanceMinandHDRLuminanceMax.FFFrameInterpolator::QueryHDRLuminanceRangeis modified to check if the user has overridden the default hardcoded values via env var or INI setting and prefers to use those values first ifEnableHDRLuminanceOverrideis true and a custom value has been provided.An example of the INI configuration file would look like this:
It didn't occur to me to commit an updated INI file example along with this, but I can do that if you'd like to merge this in. I've tested it on a few games and it appears to be working correctly.