Skip to content

Update nix and fix armv7/armhf test errors#664

Merged
Nukesor merged 2 commits intoNukesor:mainfrom
strophy:update-nix
Mar 2, 2026
Merged

Update nix and fix armv7/armhf test errors#664
Nukesor merged 2 commits intoNukesor:mainfrom
strophy:update-nix

Conversation

@strophy
Copy link
Contributor

@strophy strophy commented Mar 1, 2026

Resolves remaining issues from #658 by upstreaming patches for edge cases discovered in Alpine CI: https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/96716

No need to do another release or test these obscure platforms, I'll try and keep this package updated on Alpine and come back to you if we hit any more arch-specific issues. 🍻

Checklist

Please make sure the PR adheres to this project's standards:

  • I included a new entry to the CHANGELOG.md.
  • I checked cargo clippy and cargo fmt. The CI will fail otherwise anyway.
  • (If applicable) I added tests for this feature or adjusted existing tests.
  • (If applicable) I checked if anything in the wiki needs to be changed.

@codecov
Copy link

codecov bot commented Mar 1, 2026

Codecov Report

❌ Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.81%. Comparing base (49c8baf) to head (5e34f5b).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pueue_lib/src/network/protocol.rs 87.50% 1 Missing ⚠️
pueue_lib/src/network_blocking/protocol.rs 87.50% 1 Missing ⚠️

❌ Your project status has failed because the head coverage (76.81%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #664      +/-   ##
==========================================
+ Coverage   76.80%   76.81%   +0.01%     
==========================================
  Files          95       95              
  Lines        5772     5776       +4     
==========================================
+ Hits         4433     4437       +4     
  Misses       1339     1339              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Owner

@Nukesor Nukesor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat, thanks!

Should I publish another release?

@Nukesor Nukesor merged commit 0129adf into Nukesor:main Mar 2, 2026
25 of 26 checks passed
@strophy
Copy link
Contributor Author

strophy commented Mar 2, 2026

Sure, then I can drop these changes as patches from Alpine and see if I can make any progress on loongarch64 there.

@Nukesor
Copy link
Owner

Nukesor commented Mar 2, 2026

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants