Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
f24d840
Run CI on next
wagenet Jun 10, 2025
2c64b52
Merge remote-tracking branch 'origin/main' into next
wagenet Jun 10, 2025
16e8ed7
Kill Evented
wagenet Jun 6, 2025
9d26e9e
Merge pull request #20917 from wagenet/kill-evented
wagenet Jun 10, 2025
03416b1
Kill ArrayProxy, ObjectProxy, and PromiseProxy
wagenet Jun 7, 2025
14dd191
Merge pull request #20918 from wagenet/kill-proxy
wagenet Jun 10, 2025
f388229
Kill Comparable
wagenet Jun 7, 2025
c902478
Merge pull request #20924 from wagenet/kill-comparable
wagenet Jun 10, 2025
e0e4332
Kill ChildViewsSupport mixin
wagenet Jun 7, 2025
4b0041d
Kill ClassNamesSupport
wagenet Jun 10, 2025
75427e7
Kill ViewStateSupport mixin
wagenet Jun 8, 2025
e3b123c
Kill ViewMixin
wagenet Jun 9, 2025
f0691a7
Fix TS 5.0
wagenet Jun 11, 2025
f74a525
Merge pull request #20925 from wagenet/kill-view-mixins
wagenet Jun 11, 2025
e7291d5
Kill ActionHandler mixin
wagenet Jun 7, 2025
a6760ec
Kill TargetActionSupport
wagenet Jun 7, 2025
6d514d5
Merge pull request #20919 from wagenet/kill-more-mixins
wagenet Jun 11, 2025
1fa44dc
Kill Array mixins, some computed macros
wagenet Jun 10, 2025
251eae8
Kill ObservableMixin, EmberObject no longer uses mixins!
wagenet Jun 9, 2025
4c16999
Kill ControllerMixin
wagenet Jun 9, 2025
62fd793
Inline lifecycle methods
wagenet Jun 10, 2025
3e644c9
Kill Enumerable
wagenet Jun 11, 2025
545f883
Kill ContainerProxyMixin
wagenet Jun 11, 2025
e62120a
Merge pull request #20921 from wagenet/kill-array-mixins
wagenet Jun 11, 2025
990fb41
Kill RegistryProxy Mixin
wagenet Jun 11, 2025
c4ac932
Merge remote-tracking branch 'origin/main' into next
wagenet Jun 11, 2025
5f6dc83
Don't attempt to publish next branch to s3
wagenet Jun 11, 2025
ab874bc
Merge pull request #20928 from emberjs/kill-even-more-mixins
wagenet Jun 11, 2025
33e4fba
Better estimation of asset sizes (#20927)
NullVoxPopuli Jun 12, 2025
6c10eb8
eh
NullVoxPopuli Jun 13, 2025
c3e96c9
eh
NullVoxPopuli Jun 13, 2025
d4c9834
ope
NullVoxPopuli Jun 13, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/actions/setup/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ inputs:
description: 'Whether to use the lockfile vs latest floating dependencies'
required: false
default: true

node-version:
description: 'The node version to use'
required: false
default: 18
runs:
using: 'composite'
steps:
Expand All @@ -15,7 +20,7 @@ runs:
- name: Install Node.js
uses: actions/setup-node@v4
with:
node-version: 18
node-version: '${{ inputs.node-version }}'
registry-url: 'https://registry.npmjs.org'
cache: pnpm
- uses: actions/cache@v4
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ on:
- main
- beta
- release
- next
# release branches
- release*
- lts*
Expand Down Expand Up @@ -238,8 +239,8 @@ jobs:
blueprint-test,
browser-test,
]
# Only run on pushes to branches that are not from the cron workflow
if: github.event_name == 'push' && contains(github.ref, 'cron') != true
# Only run on pushes to branches that are not from the cron workflow or the next branch
if: github.event_name == 'push' && contains(github.ref, 'cron') != true && contains(github.ref, 'next') != true
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/setup
Expand Down
29 changes: 11 additions & 18 deletions .github/workflows/size-comment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,6 @@ jobs:
runs-on: 'ubuntu-latest'

steps:
# better `du`
- run: sudo snap install dust

- uses: dawidd6/action-download-artifact@v9
with:
run_id: ${{ inputs.RUN_ID || github.event.workflow_run.id }}
Expand Down Expand Up @@ -67,7 +64,7 @@ jobs:
echo $contents
echo "prNumber=$contents" >> $GITHUB_OUTPUT

- name: "[PR] Get sizes for development outputs"
- name: "[PR] Get sizes"
id: dev
run: |
cat ${{ steps.find-pr-txt.outputs.txtPath }}
Expand All @@ -77,7 +74,7 @@ jobs:
done <<< $(cat ${{ steps.find-pr-txt.outputs.txtPath }})
echo 'EOF' >> $GITHUB_OUTPUT

- name: "[Main] Get sizes for development outputs"
- name: "[Main] Get sizes"
id: main-dev
run: |
cd main/
Expand All @@ -89,13 +86,13 @@ jobs:
done <<< $(cat out.txt)
echo 'EOF' >> $GITHUB_OUTPUT

- name: "[Dev] calculate diff"
- name: "calculate diff"
run: |
# diff exits with status 1 if there is a diff
diff -u main/out.txt ${{ steps.find-pr-txt.outputs.txtPath }} > dev-diff.txt || echo "Differences exist"
cat dev-diff.txt

- name: "[Dev] store diff in GITHUB_OUTPUT"
- name: "store diff in GITHUB_OUTPUT"
id: dev-diff
run: |
echo 'diffText<<EOF' >> $GITHUB_OUTPUT
Expand All @@ -106,7 +103,7 @@ jobs:



- name: "[Debug] collected data from artifacts"
- name: "collected data from artifacts"
run: |
echo "PR number"
echo -e "${{ steps.find-pr-number.outputs.prNumber }}"
Expand All @@ -124,20 +121,16 @@ jobs:
#########################
# Intended Layout:
#
# | | This PR | Main |
# | Dev | x1 | y1 |
# | Prod | x2 | y2 |
#
# NOTE: we we don't have a prod build for this library
# because we currently expect non-compiler usage
# (so consumers should have terser or similar properly configured for DCE)
# | This PR | Main |
# | x1 | y1 |
# | x2 | y2 |
#
#########################
- uses: mshick/add-pr-comment@v2
with:
issue: ${{ steps.find-pr-number.outputs.prNumber }}
message: |
<details><summary>Development Assets</summary>
<details><summary>Estimated Asset Sizes</summary>

Diff

Expand All @@ -147,9 +140,9 @@ jobs:

Details

<table><thead><tr><th></th><th>This PR</th><th>main</th></tr></thead>
<table><thead><tr><th>This PR</th><th>main</th></tr></thead>
<tbody>
<tr><td>Dev</td><td>
<tr><td>

```
${{ steps.dev.outputs.sizes }}
Expand Down
15 changes: 4 additions & 11 deletions .github/workflows/size-main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,22 +13,15 @@ jobs:
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/setup
- run: sudo snap install dust
with:
node-version: 22
- run: pnpm build

- name: "Get sizes for development outputs"
- name: "Get estimated sizes for production outputs"
id: main-dev
run: |
mkdir -p main
cd dist/packages
dust --ignore_hidden \
--reverse --apparent-size \
--no-percent-bars \
--only-dir \
--depth 20 \
> out.txt
cp out.txt ../../main/

node ./bin/minify-assets.mjs > ./main/out.txt

- uses: actions/upload-artifact@v4
with:
Expand Down
15 changes: 4 additions & 11 deletions .github/workflows/size-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,25 +18,18 @@ jobs:
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/setup
with:
node-version: 22
- run: pnpm build
- run: sudo snap install dust

- name: Save PR number
run: |
mkdir -p ./pr
echo "${{ github.event.number }}" > ./pr/NR

- name: "Get sizes for development outputs"
- name: "Get estimated sizes for production outputs"
id: dev
run: |
cd dist/packages
dust --ignore_hidden \
--reverse --apparent-size \
--no-percent-bars \
--only-dir \
--depth 20 \
> out.txt
cp out.txt ../../pr/
run: node ./bin/minify-assets.mjs > ./pr/out.txt


- uses: actions/upload-artifact@v4
Expand Down
Loading