Skip to content

chore - bump version since an earlier PR was marked as major on githu… #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

chore - bump version since an earlier PR was marked as major on githu… #172

wants to merge 2 commits into from

Conversation

@juicetin
Copy link
Contributor

@juicetin juicetin commented Apr 17, 2025 •
edited
Loading

…b releases

Description

  • an earlier PR was tagged as major (regretting it now, don't think it's something I can undo and roll back to v1?), I think I need to update the package path to include v2 to be able to include the v2 dependency / import it successfully

Test Plan

Please include steps to test the change. Include screenshots if applicable.

Checklist

  • I have performed a self-review of my own code
  • I have checked for redundant or commented out code
  • I have made corresponding changes to the documentation
  • I have added any appropriate tests

@juicetin juicetin added the patch label Apr 17, 2025
@juicetin juicetin self-assigned this Apr 17, 2025
@juicetin juicetin marked this pull request as draft April 17, 2025 04:05
@juicetin juicetin force-pushed the chore/fix-version branch 3 times, most recently from fa7d08d to 25b7e96 Compare April 17, 2025 04:24
@juicetin juicetin force-pushed the chore/fix-version branch from 25b7e96 to 2bee872 Compare April 17, 2025 04:25
@juicetin juicetin marked this pull request as ready for review April 17, 2025 04:45
@juicetin juicetin closed this Apr 17, 2025
tim-thacker-nullify
tim-thacker-nullify requested changes Apr 17, 2025
View reviewed changes
Copy link
Member

@tim-thacker-nullify tim-thacker-nullify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can use v1.46.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tim-thacker-nullify tim-thacker-nullify tim-thacker-nullify requested changes

@ATMackay ATMackay Awaiting requested review from ATMackay

@vik-nullify vik-nullify Awaiting requested review from vik-nullify

Assignees

@juicetin juicetin

Labels

patch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@juicetin @tim-thacker-nullify