Add assertion in produce method to check buffer capacity in implementations for BufWriter

[pluveto]

No description provided.

[NobodyXu]

Thank you!

I think it makes sense to panic if implementation of underlying I/O objects is wrong.

How do you think @robjtede ?

[link2xt]

I generally prefer debug_assert! so libraries do not panic in production. Using assert! is not much better than using .unwrap() "because this should never return an error". It is very hard to debug a mobile app and get logs from a user when the app crashes because something in compression library decided to panic.

[NobodyXu]

I generally prefer debug_assert! so libraries do not panic in production. Using assert! is not much better than using .unwrap() "because this should never return an error". It is very hard to debug a mobile app and get logs from a user when the app crashes because something in compression library decided to panic.

Thanks I think that makes sense to me

Applied the suggestion

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (eb7abe2) to head (292ea4c).
Report is 25 commits behind head on main.

Additional details and impacted files

@@     Coverage Diff     @@
##   main   #316   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.