Replace xz2 dependency by liblzma enabling WebAssembly WASI targets #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liblzma is a drop-in replacement for xz2. It uses a new liblzma version and supports targeting WebAssembly.
This is required for "cargo build --lib" to not activate Tokio features from dev-dependencies. Otherwise, the build fails on WebAssembly.
Contributor
Author
|
The test failure seems to be unrelated. |
Collaborator
|
Hello it should be fixed on develop, rebasing should fix it |
Contributor
Author
|
Should be fixed now. I accidentally "refactored" a test artifact. |
NobodyXu
requested changes
Feb 27, 2025
Collaborator
NobodyXu
left a comment
NobodyXu
left a comment
There was a problem hiding this comment.
Thank you!
Just some changes requested for features
robjtede
approved these changes
Feb 28, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #326 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
liblzma is a drop-in replacement for xz2. It supports building to wasm32-wasip1-* targets.
In addition the Cargo resolver is switched to version 2, to prevent feature flags from dev-dependencies to leak into a
cargo build --libinvocation. This is necessary to ensure that no Tokio-features that are unsupported on WebAssembly are enabled.A CI build targeting wasm32-wasip1-threads is added.