publish: exclude testing artifacts from being published #376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
About 170KB, not a lot for individual tarball but given how many downloads are made it's indeed quite large Signed-off-by: Jiahao XU <[email protected]>
Member
|
Yea I've seen Debian and Nix packagers complain about this sort of thing in the past. Hmm. |
Collaborator
Author
|
Closing since we probably don't want to break the debian/nix packaging system |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #376 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About 170KB, not a lot for individual tarball but given how many downloads are made from crates.io it's indeed quite large
It can be seem as a kind of optimization for crates.io CDN and caching
IIRC another crate has done the same and some debian maintainers have complained about not being about to run test, but I can't remember which.
Not sure if our crate is on debian given that we don't even maintian MSRV