Flush compressed data out of encoders more often #383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently flush() is not getting called so compressed output is not returned to the client the encoder until input is fully read(). In my use case, flushing more often is necessary as otherwise it appears to the client the data gets 'buffered'. There's been a previous PR here and some discussion Nullus157#155 but appears to be abandonded so if there's interest in this fix, this PR tries this again. The tests are passing with this change.
NobodyXu
requested changes
Sep 24, 2025
Collaborator
NobodyXu
left a comment
NobodyXu
left a comment
There was a problem hiding this comment.
Thank you!
can you also update the futures bufread encoder as well?
It's equivalent to the tokio implementation.
Contributor
Author
Sure, updated it just now. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #383 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Released in 0.4.31 |
DorianNiemiecSVRJS
pushed a commit
to DorianNiemiecSVRJS/async-compression
that referenced
this pull request
Dec 21, 2025
* Flush compressed data out of encoders more often Currently flush() is not getting called so compressed output is not returned to the client the encoder until input is fully read(). In my use case, flushing more often is necessary as otherwise it appears to the client the data gets 'buffered'. There's been a previous PR here and some discussion Nullus157#155 but appears to be abandonded so if there's interest in this fix, this PR tries this again. The tests are passing with this change. * Update futures bufread futures encoder to add more flushes It's equivalent to the tokio implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently flush() is not getting called so compressed output is not returned to the client the encoder until input is fully read(). In my use case, flushing more often is necessary as otherwise it appears to the client the data gets 'buffered'.
There's been a previous PR here and some discussion #155 but appears to be abandonded so if there's interest in this fix, this PR tries this again.
The tests are passing with this change.