Skip to content

Optimize GzipEncoder to not allocate for header and footer #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NobodyXu merged 1 commit into from
Dec 7, 2025
Merged

Optimize GzipEncoder to not allocate for header and footer #431

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions crates/compression-codecs/src/gzip/encoder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ use std::io;

#[derive(Debug)]
enum State {
Header(PartialBuffer<Vec<u8>>),
Header(PartialBuffer<[u8; 10]>),
Encoding,
Footer(PartialBuffer<Vec<u8>>),
Footer(PartialBuffer<[u8; 8]>),
Done,
}

Expand All @@ -18,7 +18,7 @@ pub struct GzipEncoder {
state: State,
}

fn header(level: Compression) -> Vec<u8> {
fn header(level: Compression) -> [u8; 10] {
let level_byte = if level.level() >= Compression::best().level() {
0x02
} else if level.level() <= Compression::fast().level() {
Expand All @@ -27,7 +27,7 @@ fn header(level: Compression) -> Vec<u8> {
0x00
};

vec![0x1f, 0x8b, 0x08, 0, 0, 0, 0, 0, level_byte, 0xff]
[0x1f, 0x8b, 0x08, 0, 0, 0, 0, 0, level_byte, 0xff]
}

impl GzipEncoder {
Expand All @@ -39,11 +39,11 @@ impl GzipEncoder {
}
}

fn footer(&mut self) -> Vec<u8> {
let mut output = Vec::with_capacity(8);
fn footer(&mut self) -> [u8; 8] {
let mut output = [0; 8];

output.extend(&self.crc.sum().to_le_bytes());
output.extend(&self.crc.amount().to_le_bytes());
output[..4].copy_from_slice(&self.crc.sum().to_le_bytes());
output[4..].copy_from_slice(&self.crc.amount().to_le_bytes());

output
}
Expand Down