Fix update of bytes read in the encoder state machine.#456
Open
orium wants to merge 1 commit intoNullus157:mainfrom
Open
Fix update of bytes read in the encoder state machine.#456orium wants to merge 1 commit intoNullus157:mainfrom
orium wants to merge 1 commit intoNullus157:mainfrom
Conversation
orium
force-pushed
the
fix-flush-encoder
branch
from
494f082 to
5996a6f
Compare
Contributor
Author
|
I'll try to add a test for this. Right now I'm investigating the failing tests. |
Contributor
Author
This seems to be another bug introduced in 8947fed. I've reverted that commit in this PR (first commit). I think the bug is that we were turning some |
orium
changed the title
orium
changed the title
orium
changed the title
orium
force-pushed
the
fix-flush-encoder
branch
from
4ed8167 to
2954200
Compare
Contributor
Author
|
@NobodyXu This should be ready for review now. |
NobodyXu
requested changes
Feb 13, 2026
Collaborator
NobodyXu
left a comment
NobodyXu
left a comment
There was a problem hiding this comment.
Thanks the encoder the change look good to me, but the decoder change really got me confused on what exactly is changed (its behavior is identical before and after this PR) and not related to this PR, can we have the decoder change reverted please?
crates/async-compression/src/futures/bufread/generic/decoder.rs
Outdated
Show resolved
Hide resolved
orium
force-pushed
the
fix-flush-encoder
branch
from
2954200 to
f87860a
Compare
NobodyXu
reviewed
Feb 13, 2026
Previously we were not updating the number of bytes read: we were just changing the local binding of `read`. This means that read was always zero and therefore the encoder never flushed. Fixes Nullus157#455.
orium
force-pushed
the
fix-flush-encoder
branch
from
f87860a to
a093589
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we were not updating the number of bytes read: we were just changing the local binding of
read. This means that read was always zero and therefore the encoder never flushed.Fixes #455