Add mountain wave validation case and support naive solver for topography

[glwagner]

cc @kaiyuan-cheng

[codecov]

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/AtmosphereModels/anelastic_formulation.jl	50.00%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

[giordano]

Should the new validation script be run in CI? Maybe after #67, because that touches the Validation workflow

[glwagner]

Should the new validation script be run in CI? Maybe after #67, because that touches the Validation workflow

One issue with always running validation in CI is that there will probably need to be some heavy validation cases. So we may not be able to run them all (or at least not all the time... maybe infrequently, eg nightly or weekly)

Another thought is that I think its nice to implement validation cases as "examples" which get built into the documentation (Oceananigans does this to some extent, though we may be able to do an even better job here).

However one may want to have additional validation cases that are not examples. Some of the non-example validation cases could be lightweight enough to run regularly in CI.

Maybe we can flesh out a strategy that incorporates these considerations?

[navidcy]

Yes. Agree.

It's bit tricky to run the validation cases in a CI. Especially if validation cases also start plotting things and one needs to visually inspect to ensure that nothing changed. An idea would be that validation scripts finish at

run!(simulation)

plus perhaps a very simple test after (eg something to ensure the flow is not nonsense?)

simulation.model.tracers.temperature < 300

And then different scripts for plotting? It does make the validation directory a bit more complex...

[glwagner]

Possibly we want to implement validation tests as regression tests.

[kaiyuan-cheng]

This mountain wave case is not working too well in terms of speed and fidelity for the following reasons

1. Immersed boundary requires very high resolution to resolve the short mountain.
2. Open boundary condition is needed to improve the solution.

At least, the phase of the most significant wave looks not too bad!