Skip to content

Conversation

@glwagner
Copy link
Member

@glwagner glwagner commented Nov 8, 2025

@codecov
Copy link

codecov bot commented Nov 8, 2025

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/AtmosphereModels/anelastic_formulation.jl 0.00% 1 Missing ⚠️
src/MoistAirBuoyancies.jl 0.00% 1 Missing ⚠️
src/Thermodynamics/reference_states.jl 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@glwagner
Copy link
Member Author

glwagner commented Nov 8, 2025

@giordano the free convection case needs a little grooming to run (so I haven't checked if this works yet). I have to run now but feel free to push changes here

@glwagner glwagner changed the title Add adapt_structure for MoistAirBuoyancy and ReferenceState [GPU] Add adapt_structure for MoistAirBuoyancy and ReferenceState Nov 8, 2025
@glwagner glwagner changed the title [GPU] Add adapt_structure for MoistAirBuoyancy and ReferenceState [GPU] Add adapt_structure for MoistAirBuoyancy, AnelasticFormulation, and ReferenceState Nov 8, 2025
@glwagner
Copy link
Member Author

glwagner commented Nov 8, 2025

@kaiyuan-cheng this commit allowed AtmosphereModel to run on GPU: 01e8f2a

hopefully we will have tests soon.

@glwagner glwagner requested a review from giordano November 8, 2025 19:37
Copy link
Collaborator

@giordano giordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm this fixes #72 (comment) 🚀

@giordano giordano merged commit 677347b into main Nov 8, 2025
7 of 8 checks passed
@giordano giordano deleted the glw/gpu-fixes branch November 8, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants