-
Notifications
You must be signed in to change notification settings - Fork 4
[DO NOT MERGE] JOSS paper draft #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Benchmark Results (Julia v1.10)Time benchmarks
Memory benchmarks
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Pull Request Test Coverage Report for Build 19245083453Details
💛 - Coveralls |
Co-authored-by: Collin Wittenstein <[email protected]>
Co-authored-by: Collin Wittenstein <[email protected]>
Co-authored-by: Collin Wittenstein <[email protected]>
|
I feel like I should click "start review" and not "add single comment" all the time 🙈 |
Co-authored-by: Collin Wittenstein <[email protected]>
Co-authored-by: Collin Wittenstein <[email protected]>
|
I was able to go through everything now. I am not to familiar with JOSS Papers but it looks good to me. Thanks a lot for setting it up! :) |
|
Thanks for your feedback! |
Co-authored-by: Collin Wittenstein <[email protected]>
|
@JoshuaLampert I added some additional references to other software. Please check them. |
|
I guess we should also cite https://github.com/CliMA/Oceananigans.jl |
|
What about also citing TrixiShallowWater.jl? It also has multilayer SWE, which are non-hydrostatic/dispersive, right? |
|
Right, good idea 👍 |
|
I added a sentence mentioning Oceananigans.jl and TrixiShallowWater.jl. I am not sure how much/what we should write about how they relate to DispersiveShallowWater.jl. For example for TrixiShallowWater.jl I would say probably the main difference is that TrixiShallowWater.jl relies on models that can be written as balance law only including first-order derivatives while the focus of DispersiveShallowWater.jl lies more on equations with higher-order derivatives (which also was the main reason why I didn't try to integrate the methods directly into Trixi.jl), but this becomes a bit technical. |
|
The current sentence should be fine, I think. Thanks! |
DO NOT MERGE THIS PR
We can use this PR to check and discuss the paper draft. The PR can be closed when the JOSS paper is finished. The branch
paper-2025-jossmust be kept around forever.You can download the PDF of the paper draft from the GitHub action
Build JOSS paper draft PDF / JOSS Paper Draft (pull_request)below.Summaryon the left