Skip to content

Conversation

@JoshuaLampert
Copy link
Member

DO NOT MERGE THIS PR

We can use this PR to check and discuss the paper draft. The PR can be closed when the JOSS paper is finished. The branch paper-2025-joss must be kept around forever.

You can download the PDF of the paper draft from the GitHub action Build JOSS paper draft PDF / JOSS Paper Draft (pull_request) below.

  • Click on it
  • Go to Summary on the left
  • Download the artifact

@JoshuaLampert JoshuaLampert changed the title Add first JOSS paper draft [DO NOT MERGE] JOSS paper draft Aug 21, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 21, 2025

Benchmark Results (Julia v1.10)

Time benchmarks
main 441b6a3... main / 441b6a3...
bbm_1d/bbm_1d_basic.jl - rhs!: 14 ± 0.33 μs 13.8 ± 0.29 μs 1.01 ± 0.032
bbm_1d/bbm_1d_fourier.jl - rhs!: 0.224 ± 0.31 ms 0.215 ± 0.071 ms 1.04 ± 1.5
bbm_bbm_1d/bbm_bbm_1d_basic_reflecting.jl - rhs!: 0.0814 ± 0.00026 ms 0.0805 ± 0.00031 ms 1.01 ± 0.0051
bbm_bbm_1d/bbm_bbm_1d_dg.jl - rhs!: 0.0342 ± 0.00044 ms 0.0353 ± 0.00049 ms 0.969 ± 0.018
bbm_bbm_1d/bbm_bbm_1d_relaxation.jl - rhs!: 27.4 ± 0.48 μs 29.8 ± 1.4 μs 0.921 ± 0.046
bbm_bbm_1d/bbm_bbm_1d_upwind_relaxation.jl - rhs!: 0.0492 ± 0.00056 ms 0.0489 ± 0.00044 ms 1.01 ± 0.015
hyperbolic_serre_green_naghdi_1d/hyperbolic_serre_green_naghdi_dingemans.jl - rhs!: 4.22 ± 0.03 μs 4.25 ± 0.031 μs 0.993 ± 0.01
kdv_1d/kdv_1d_basic.jl - rhs!: 1.45 ± 0.02 μs 1.43 ± 0.021 μs 1.01 ± 0.02
kdv_1d/kdv_1d_implicit.jl - rhs!: 1.41 ± 0.02 μs 1.44 ± 0.01 μs 0.979 ± 0.015
serre_green_naghdi_1d/serre_green_naghdi_well_balanced.jl - rhs!: 0.201 ± 0.007 ms 0.197 ± 0.0065 ms 1.02 ± 0.049
svaerd_kalisch_1d/svaerd_kalisch_1d_dingemans_relaxation.jl - rhs!: 0.149 ± 0.0047 ms 0.145 ± 0.0035 ms 1.03 ± 0.041
time_to_load 1.95 ± 0.008 s 1.94 ± 0.0021 s 1.01 ± 0.0043
Memory benchmarks
main 441b6a3... main / 441b6a3...
bbm_1d/bbm_1d_basic.jl - rhs!: 1 allocs: 4.12 kB 1 allocs: 4.12 kB 1
bbm_1d/bbm_1d_fourier.jl - rhs!: 1 allocs: 4.12 kB 1 allocs: 4.12 kB 1
bbm_bbm_1d/bbm_bbm_1d_basic_reflecting.jl - rhs!: 5 allocs: 1.17 kB 5 allocs: 1.17 kB 1
bbm_bbm_1d/bbm_bbm_1d_dg.jl - rhs!: 10 allocs: 8.62 kB 10 allocs: 8.62 kB 1
bbm_bbm_1d/bbm_bbm_1d_relaxation.jl - rhs!: 2 allocs: 8.25 kB 2 allocs: 8.25 kB 1
bbm_bbm_1d/bbm_bbm_1d_upwind_relaxation.jl - rhs!: 2 allocs: 8.25 kB 2 allocs: 8.25 kB 1
hyperbolic_serre_green_naghdi_1d/hyperbolic_serre_green_naghdi_dingemans.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
kdv_1d/kdv_1d_basic.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
kdv_1d/kdv_1d_implicit.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
serre_green_naghdi_1d/serre_green_naghdi_well_balanced.jl - rhs!: 0.075 k allocs: 0.66 MB 0.075 k allocs: 0.66 MB 1
svaerd_kalisch_1d/svaerd_kalisch_1d_dingemans_relaxation.jl - rhs!: 0.042 k allocs: 0.315 MB 0.042 k allocs: 0.315 MB 1
time_to_load 0.153 k allocs: 14.5 kB 0.153 k allocs: 14.5 kB 1

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@coveralls
Copy link
Collaborator

coveralls commented Aug 21, 2025

Pull Request Test Coverage Report for Build 19245083453

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.552%

Totals Coverage Status
Change from base Build 19244971971: 0.0%
Covered Lines: 2314
Relevant Lines: 2348

💛 - Coveralls

@JoshuaLampert
Copy link
Member Author

I made a first draft for the paper. I'm happy to hear your suggestions and feedback, @ranocha and @cwittens.

Co-authored-by: Collin Wittenstein <[email protected]>
Co-authored-by: Collin Wittenstein <[email protected]>
Co-authored-by: Collin Wittenstein <[email protected]>
@cwittens
Copy link
Member

I feel like I should click "start review" and not "add single comment" all the time 🙈

Co-authored-by: Collin Wittenstein <[email protected]>
@JoshuaLampert JoshuaLampert marked this pull request as draft August 21, 2025 19:16
Co-authored-by: Collin Wittenstein <[email protected]>
@cwittens
Copy link
Member

I was able to go through everything now. I am not to familiar with JOSS Papers but it looks good to me. Thanks a lot for setting it up! :)

@JoshuaLampert
Copy link
Member Author

Thanks for your feedback!

@ranocha
Copy link
Member

ranocha commented Aug 22, 2025

@JoshuaLampert I added some additional references to other software. Please check them.

@ranocha
Copy link
Member

ranocha commented Aug 22, 2025

I guess we should also cite https://github.com/CliMA/Oceananigans.jl

@JoshuaLampert
Copy link
Member Author

What about also citing TrixiShallowWater.jl? It also has multilayer SWE, which are non-hydrostatic/dispersive, right?

@ranocha
Copy link
Member

ranocha commented Aug 22, 2025

Right, good idea 👍

@JoshuaLampert
Copy link
Member Author

JoshuaLampert commented Aug 22, 2025

I added a sentence mentioning Oceananigans.jl and TrixiShallowWater.jl. I am not sure how much/what we should write about how they relate to DispersiveShallowWater.jl. For example for TrixiShallowWater.jl I would say probably the main difference is that TrixiShallowWater.jl relies on models that can be written as balance law only including first-order derivatives while the focus of DispersiveShallowWater.jl lies more on equations with higher-order derivatives (which also was the main reason why I didn't try to integrate the methods directly into Trixi.jl), but this becomes a bit technical.

@ranocha
Copy link
Member

ranocha commented Aug 23, 2025

The current sentence should be fine, I think. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants