Skip to content

Update Zenodo title#236

Merged
JoshuaLampert merged 2 commits intomainfrom
ranocha-patch-1
Aug 22, 2025
Merged

Update Zenodo title#236
JoshuaLampert merged 2 commits intomainfrom
ranocha-patch-1

Conversation

@ranocha
Copy link
Copy Markdown
Member

@ranocha ranocha commented Aug 22, 2025

We have to use the same title for the paper developed in #235 and Zenodo.

@ranocha ranocha requested a review from JoshuaLampert August 22, 2025 06:18
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 22, 2025

Benchmark Results (Julia v1.10)

Time benchmarks
main e24e54c... main / e24e54c...
bbm_1d/bbm_1d_basic.jl - rhs!: 14.3 ± 0.44 μs 13.7 ± 0.26 μs 1.05 ± 0.038
bbm_1d/bbm_1d_fourier.jl - rhs!: 0.217 ± 0.31 ms 0.527 ± 0.21 ms 0.412 ± 0.61
bbm_bbm_1d/bbm_bbm_1d_basic_reflecting.jl - rhs!: 0.0812 ± 0.0012 ms 0.0806 ± 0.00037 ms 1.01 ± 0.015
bbm_bbm_1d/bbm_bbm_1d_dg.jl - rhs!: 0.0344 ± 0.00051 ms 0.0344 ± 0.00049 ms 1 ± 0.021
bbm_bbm_1d/bbm_bbm_1d_relaxation.jl - rhs!: 27.1 ± 0.39 μs 26.9 ± 0.4 μs 1.01 ± 0.021
bbm_bbm_1d/bbm_bbm_1d_upwind_relaxation.jl - rhs!: 0.0484 ± 0.00044 ms 0.0488 ± 0.00066 ms 0.992 ± 0.016
hyperbolic_serre_green_naghdi_1d/hyperbolic_serre_green_naghdi_dingemans.jl - rhs!: 4.29 ± 0.04 μs 4.28 ± 0.03 μs 1 ± 0.012
kdv_1d/kdv_1d_basic.jl - rhs!: 1.46 ± 0.02 μs 1.81 ± 0.021 μs 0.807 ± 0.014
kdv_1d/kdv_1d_implicit.jl - rhs!: 1.45 ± 0.02 μs 1.42 ± 0.02 μs 1.02 ± 0.02
serre_green_naghdi_1d/serre_green_naghdi_well_balanced.jl - rhs!: 0.197 ± 0.0083 ms 0.201 ± 0.0086 ms 0.983 ± 0.059
svaerd_kalisch_1d/svaerd_kalisch_1d_dingemans_relaxation.jl - rhs!: 0.145 ± 0.0038 ms 0.148 ± 0.0044 ms 0.982 ± 0.039
time_to_load 1.88 ± 0.0059 s 1.89 ± 0.022 s 0.995 ± 0.012
Memory benchmarks
main e24e54c... main / e24e54c...
bbm_1d/bbm_1d_basic.jl - rhs!: 1 allocs: 4.12 kB 1 allocs: 4.12 kB 1
bbm_1d/bbm_1d_fourier.jl - rhs!: 1 allocs: 4.12 kB 1 allocs: 4.12 kB 1
bbm_bbm_1d/bbm_bbm_1d_basic_reflecting.jl - rhs!: 5 allocs: 1.17 kB 5 allocs: 1.17 kB 1
bbm_bbm_1d/bbm_bbm_1d_dg.jl - rhs!: 10 allocs: 8.62 kB 10 allocs: 8.62 kB 1
bbm_bbm_1d/bbm_bbm_1d_relaxation.jl - rhs!: 2 allocs: 8.25 kB 2 allocs: 8.25 kB 1
bbm_bbm_1d/bbm_bbm_1d_upwind_relaxation.jl - rhs!: 2 allocs: 8.25 kB 2 allocs: 8.25 kB 1
hyperbolic_serre_green_naghdi_1d/hyperbolic_serre_green_naghdi_dingemans.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
kdv_1d/kdv_1d_basic.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
kdv_1d/kdv_1d_implicit.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
serre_green_naghdi_1d/serre_green_naghdi_well_balanced.jl - rhs!: 0.075 k allocs: 0.66 MB 0.075 k allocs: 0.66 MB 1
svaerd_kalisch_1d/svaerd_kalisch_1d_dingemans_relaxation.jl - rhs!: 0.042 k allocs: 0.315 MB 0.042 k allocs: 0.315 MB 1
time_to_load 0.153 k allocs: 14.5 kB 0.153 k allocs: 14.5 kB 1

Copy link
Copy Markdown
Member

@JoshuaLampert JoshuaLampert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>
@ranocha ranocha requested a review from JoshuaLampert August 22, 2025 07:52
Copy link
Copy Markdown
Member

@JoshuaLampert JoshuaLampert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JoshuaLampert JoshuaLampert merged commit 843f832 into main Aug 22, 2025
3 checks passed
@JoshuaLampert JoshuaLampert deleted the ranocha-patch-1 branch August 22, 2025 08:01
@JoshuaLampert
Copy link
Copy Markdown
Member

I just realize: Now the Zenodo title is different to how we recommend citing DispersiveShallowWater.jl. Should the titles be the same or doesn't it matter?

@ranocha
Copy link
Copy Markdown
Member Author

ranocha commented Aug 22, 2025

The Zenodo title has to be the same as the JOSS paper title. I think it is fine to keep the citation recommendation we use at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants