Skip to content

Update paper references#252

Merged
JoshuaLampert merged 2 commits intomainfrom
update-paper-references
Nov 10, 2025
Merged

Update paper references#252
JoshuaLampert merged 2 commits intomainfrom
update-paper-references

Conversation

@JoshuaLampert
Copy link
Copy Markdown
Member

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

Benchmark Results (Julia v1.10)

Time benchmarks
main dda723f... main / dda723f...
bbm_1d/bbm_1d_basic.jl - rhs!: 13.9 ± 0.34 μs 13.7 ± 0.37 μs 1.02 ± 0.037
bbm_1d/bbm_1d_fourier.jl - rhs!: 0.528 ± 0.19 ms 0.251 ± 0.31 ms 2.11 ± 2.7
bbm_bbm_1d/bbm_bbm_1d_basic_reflecting.jl - rhs!: 0.0807 ± 0.00043 ms 0.0805 ± 0.00041 ms 1 ± 0.0074
bbm_bbm_1d/bbm_bbm_1d_dg.jl - rhs!: 0.0344 ± 0.00047 ms 0.0342 ± 0.00082 ms 1 ± 0.028
bbm_bbm_1d/bbm_bbm_1d_relaxation.jl - rhs!: 27 ± 0.47 μs 27.2 ± 0.63 μs 0.993 ± 0.029
bbm_bbm_1d/bbm_bbm_1d_upwind_relaxation.jl - rhs!: 0.0485 ± 0.00066 ms 0.0488 ± 0.00092 ms 0.994 ± 0.023
hyperbolic_serre_green_naghdi_1d/hyperbolic_serre_green_naghdi_dingemans.jl - rhs!: 4.3 ± 0.03 μs 4.27 ± 0.04 μs 1.01 ± 0.012
kdv_1d/kdv_1d_basic.jl - rhs!: 1.43 ± 0.02 μs 1.45 ± 0.02 μs 0.987 ± 0.019
kdv_1d/kdv_1d_implicit.jl - rhs!: 1.41 ± 0.03 μs 1.44 ± 0.02 μs 0.979 ± 0.025
serre_green_naghdi_1d/serre_green_naghdi_well_balanced.jl - rhs!: 0.2 ± 0.0094 ms 0.199 ± 0.0084 ms 1 ± 0.063
svaerd_kalisch_1d/svaerd_kalisch_1d_dingemans_relaxation.jl - rhs!: 0.146 ± 0.0041 ms 0.146 ± 0.0052 ms 1 ± 0.046
time_to_load 1.98 ± 0.014 s 2 ± 0.023 s 0.991 ± 0.014
Memory benchmarks
main dda723f... main / dda723f...
bbm_1d/bbm_1d_basic.jl - rhs!: 1 allocs: 4.12 kB 1 allocs: 4.12 kB 1
bbm_1d/bbm_1d_fourier.jl - rhs!: 1 allocs: 4.12 kB 1 allocs: 4.12 kB 1
bbm_bbm_1d/bbm_bbm_1d_basic_reflecting.jl - rhs!: 5 allocs: 1.17 kB 5 allocs: 1.17 kB 1
bbm_bbm_1d/bbm_bbm_1d_dg.jl - rhs!: 10 allocs: 8.62 kB 10 allocs: 8.62 kB 1
bbm_bbm_1d/bbm_bbm_1d_relaxation.jl - rhs!: 2 allocs: 8.25 kB 2 allocs: 8.25 kB 1
bbm_bbm_1d/bbm_bbm_1d_upwind_relaxation.jl - rhs!: 2 allocs: 8.25 kB 2 allocs: 8.25 kB 1
hyperbolic_serre_green_naghdi_1d/hyperbolic_serre_green_naghdi_dingemans.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
kdv_1d/kdv_1d_basic.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
kdv_1d/kdv_1d_implicit.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
serre_green_naghdi_1d/serre_green_naghdi_well_balanced.jl - rhs!: 0.075 k allocs: 0.66 MB 0.075 k allocs: 0.66 MB 1
svaerd_kalisch_1d/svaerd_kalisch_1d_dingemans_relaxation.jl - rhs!: 0.042 k allocs: 0.315 MB 0.042 k allocs: 0.315 MB 1
time_to_load 0.153 k allocs: 14.5 kB 0.153 k allocs: 14.5 kB 1

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Did you already update the reference in the JOSS paper draft?

@JoshuaLampert
Copy link
Copy Markdown
Member Author

Ah, good point. I forgot that.

@JoshuaLampert JoshuaLampert merged commit 6ebc66c into main Nov 10, 2025
13 checks passed
@JoshuaLampert JoshuaLampert deleted the update-paper-references branch November 10, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants