Skip to content

Fix typo in conservation error string#253

Merged
JoshuaLampert merged 1 commit intoNumericalMathematics:mainfrom
pnavaro:main
Nov 17, 2025
Merged

Fix typo in conservation error string#253
JoshuaLampert merged 1 commit intoNumericalMathematics:mainfrom
pnavaro:main

Conversation

@pnavaro
Copy link
Copy Markdown
Contributor

@pnavaro pnavaro commented Nov 17, 2025

No description provided.

Copy link
Copy Markdown
Member

@JoshuaLampert JoshuaLampert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions
Copy link
Copy Markdown
Contributor

Benchmark Results (Julia v1.10)

Time benchmarks
main 8e53f32... main / 8e53f32...
bbm_1d/bbm_1d_basic.jl - rhs!: 13.9 ± 0.35 μs 14 ± 0.44 μs 0.996 ± 0.04
bbm_1d/bbm_1d_fourier.jl - rhs!: 0.217 ± 0.015 ms 0.529 ± 0.0094 ms 0.411 ± 0.029
bbm_bbm_1d/bbm_bbm_1d_basic_reflecting.jl - rhs!: 0.0806 ± 0.00029 ms 0.0806 ± 0.00039 ms 1 ± 0.006
bbm_bbm_1d/bbm_bbm_1d_dg.jl - rhs!: 0.0343 ± 0.00084 ms 0.0345 ± 0.00084 ms 0.994 ± 0.034
bbm_bbm_1d/bbm_bbm_1d_relaxation.jl - rhs!: 27.4 ± 0.51 μs 27.2 ± 0.44 μs 1.01 ± 0.025
bbm_bbm_1d/bbm_bbm_1d_upwind_relaxation.jl - rhs!: 0.049 ± 0.00074 ms 0.0486 ± 0.0025 ms 1.01 ± 0.054
hyperbolic_serre_green_naghdi_1d/hyperbolic_serre_green_naghdi_dingemans.jl - rhs!: 4.24 ± 0.04 μs 4.35 ± 0.05 μs 0.975 ± 0.015
kdv_1d/kdv_1d_basic.jl - rhs!: 1.41 ± 0.011 μs 1.43 ± 0.011 μs 0.986 ± 0.011
kdv_1d/kdv_1d_implicit.jl - rhs!: 1.41 ± 0.011 μs 1.43 ± 0.02 μs 0.985 ± 0.016
serre_green_naghdi_1d/serre_green_naghdi_well_balanced.jl - rhs!: 0.205 ± 0.0087 ms 0.2 ± 0.0089 ms 1.02 ± 0.063
svaerd_kalisch_1d/svaerd_kalisch_1d_dingemans_relaxation.jl - rhs!: 0.152 ± 0.007 ms 0.148 ± 0.004 ms 1.03 ± 0.055
time_to_load 2.05 ± 0.01 s 1.97 ± 0.012 s 1.04 ± 0.0081
Memory benchmarks
main 8e53f32... main / 8e53f32...
bbm_1d/bbm_1d_basic.jl - rhs!: 1 allocs: 4.12 kB 1 allocs: 4.12 kB 1
bbm_1d/bbm_1d_fourier.jl - rhs!: 1 allocs: 4.12 kB 1 allocs: 4.12 kB 1
bbm_bbm_1d/bbm_bbm_1d_basic_reflecting.jl - rhs!: 5 allocs: 1.17 kB 5 allocs: 1.17 kB 1
bbm_bbm_1d/bbm_bbm_1d_dg.jl - rhs!: 10 allocs: 8.62 kB 10 allocs: 8.62 kB 1
bbm_bbm_1d/bbm_bbm_1d_relaxation.jl - rhs!: 2 allocs: 8.25 kB 2 allocs: 8.25 kB 1
bbm_bbm_1d/bbm_bbm_1d_upwind_relaxation.jl - rhs!: 2 allocs: 8.25 kB 2 allocs: 8.25 kB 1
hyperbolic_serre_green_naghdi_1d/hyperbolic_serre_green_naghdi_dingemans.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
kdv_1d/kdv_1d_basic.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
kdv_1d/kdv_1d_implicit.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
serre_green_naghdi_1d/serre_green_naghdi_well_balanced.jl - rhs!: 0.075 k allocs: 0.66 MB 0.075 k allocs: 0.66 MB 1
svaerd_kalisch_1d/svaerd_kalisch_1d_dingemans_relaxation.jl - rhs!: 0.042 k allocs: 0.315 MB 0.042 k allocs: 0.315 MB 1
time_to_load 0.153 k allocs: 14.5 kB 0.153 k allocs: 14.5 kB 1

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@JoshuaLampert JoshuaLampert merged commit 4a01373 into NumericalMathematics:main Nov 17, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants