Skip to content

Clarify traveling wave solution for BBM-BBM is unphysical #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ranocha merged 1 commit into from
Nov 18, 2025
Merged

Clarify traveling wave solution for BBM-BBM is unphysical #259

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/equations/bbm_bbm_1d.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,8 @@ end

A traveling-wave solution used for convergence tests in a periodic domain.
The bathymetry is constant.
Note that the solution is unphysical as it allows for negative water heights.
It is mainly used to verify the order of convergence of a numerical method.

For details see Example 5 in Section 3 from (here adapted for dimensional equations):
- Min Chen (1997)
Expand Down