Skip to content

Change default example#276

Merged
JoshuaLampert merged 5 commits intomainfrom
change-default_example
Dec 16, 2025
Merged

Change default example#276
JoshuaLampert merged 5 commits intomainfrom
change-default_example

Conversation

@JoshuaLampert
Copy link
Copy Markdown
Member

Resolves the first part of #263.

@JoshuaLampert JoshuaLampert mentioned this pull request Dec 16, 2025
2 tasks
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 16, 2025

Benchmark Results (Julia v1.10)

Time benchmarks
main c262522... main / c262522...
bbm_1d/bbm_1d_basic.jl - rhs!: 13.9 ± 0.62 μs 13.4 ± 0.62 μs 1.04 ± 0.066
bbm_1d/bbm_1d_fourier.jl - rhs!: 0.244 ± 0.0068 ms 0.247 ± 0.0074 ms 0.989 ± 0.04
bbm_bbm_1d/bbm_bbm_1d_basic_reflecting.jl - rhs!: 0.0866 ± 0.0059 ms 0.0898 ± 0.004 ms 0.965 ± 0.079
bbm_bbm_1d/bbm_bbm_1d_dg.jl - rhs!: 0.0323 ± 0.00062 ms 0.0324 ± 0.00059 ms 0.995 ± 0.026
bbm_bbm_1d/bbm_bbm_1d_relaxation.jl - rhs!: 26.7 ± 0.98 μs 26.9 ± 0.68 μs 0.993 ± 0.044
bbm_bbm_1d/bbm_bbm_1d_upwind_relaxation.jl - rhs!: 0.0337 ± 0.0012 ms 0.0342 ± 0.0014 ms 0.986 ± 0.054
hyperbolic_serre_green_naghdi_1d/hyperbolic_serre_green_naghdi_dingemans.jl - rhs!: 6.17 ± 0.21 μs 6.03 ± 0.23 μs 1.02 ± 0.052
kdv_1d/kdv_1d_basic.jl - rhs!: 2.32 ± 0.089 μs 1.9 ± 0.021 μs 1.22 ± 0.049
kdv_1d/kdv_1d_implicit.jl - rhs!: 2.06 ± 0.046 μs 1.84 ± 0.063 μs 1.11 ± 0.045
serre_green_naghdi_1d/serre_green_naghdi_well_balanced.jl - rhs!: 0.235 ± 0.017 ms 0.226 ± 0.017 ms 1.04 ± 0.11
svaerd_kalisch_1d/svaerd_kalisch_1d_dingemans_relaxation.jl - rhs!: 0.172 ± 0.01 ms 0.167 ± 0.0088 ms 1.03 ± 0.083
time_to_load 1.99 ± 0.0092 s 1.98 ± 0.024 s 1.01 ± 0.013
Memory benchmarks
main c262522... main / c262522...
bbm_1d/bbm_1d_basic.jl - rhs!: 1 allocs: 4.12 kB 1 allocs: 4.12 kB 1
bbm_1d/bbm_1d_fourier.jl - rhs!: 1 allocs: 4.12 kB 1 allocs: 4.12 kB 1
bbm_bbm_1d/bbm_bbm_1d_basic_reflecting.jl - rhs!: 5 allocs: 1.17 kB 5 allocs: 1.17 kB 1
bbm_bbm_1d/bbm_bbm_1d_dg.jl - rhs!: 10 allocs: 8.62 kB 10 allocs: 8.62 kB 1
bbm_bbm_1d/bbm_bbm_1d_relaxation.jl - rhs!: 2 allocs: 8.25 kB 2 allocs: 8.25 kB 1
bbm_bbm_1d/bbm_bbm_1d_upwind_relaxation.jl - rhs!: 2 allocs: 8.25 kB 2 allocs: 8.25 kB 1
hyperbolic_serre_green_naghdi_1d/hyperbolic_serre_green_naghdi_dingemans.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
kdv_1d/kdv_1d_basic.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
kdv_1d/kdv_1d_implicit.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
serre_green_naghdi_1d/serre_green_naghdi_well_balanced.jl - rhs!: 0.075 k allocs: 0.66 MB 0.075 k allocs: 0.66 MB 1
svaerd_kalisch_1d/svaerd_kalisch_1d_dingemans_relaxation.jl - rhs!: 0.042 k allocs: 0.315 MB 0.042 k allocs: 0.315 MB 1
time_to_load 0.153 k allocs: 14.5 kB 0.153 k allocs: 14.5 kB 1

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@coveralls
Copy link
Copy Markdown
Collaborator

Pull Request Test Coverage Report for Build 20277552134

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.467%

Totals Coverage Status
Change from base Build 20259624630: 0.0%
Covered Lines: 2313
Relevant Lines: 2349

💛 - Coveralls

Copy link
Copy Markdown
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JoshuaLampert JoshuaLampert merged commit c3fb20c into main Dec 16, 2025
13 checks passed
@JoshuaLampert JoshuaLampert deleted the change-default_example branch December 16, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants