Skip to content

Fix JET.jl tests#283

Merged
ranocha merged 1 commit intomainfrom
fix-JET
Feb 24, 2026
Merged

Fix JET.jl tests#283
ranocha merged 1 commit intomainfrom
fix-JET

Conversation

@JoshuaLampert
Copy link
Copy Markdown
Member

Currently, we are seeing JET.jl tests failing, e.g. here. This PR should fix that.

@github-actions
Copy link
Copy Markdown
Contributor

Benchmark Results (Julia v1.10)

Time benchmarks
main 858e76f... main / 858e76f...
bbm_1d/bbm_1d_basic.jl - rhs!: 13.8 ± 0.31 μs 14 ± 0.32 μs 0.983 ± 0.032
bbm_1d/bbm_1d_fourier.jl - rhs!: 0.528 ± 0.01 ms 0.237 ± 0.32 ms 2.23 ± 3
bbm_bbm_1d/bbm_bbm_1d_basic_reflecting.jl - rhs!: 0.0805 ± 0.00044 ms 0.0805 ± 0.002 ms 1 ± 0.025
bbm_bbm_1d/bbm_bbm_1d_dg.jl - rhs!: 0.0344 ± 0.00055 ms 0.0341 ± 0.00055 ms 1.01 ± 0.023
bbm_bbm_1d/bbm_bbm_1d_relaxation.jl - rhs!: 27.7 ± 0.53 μs 27.3 ± 0.46 μs 1.02 ± 0.026
bbm_bbm_1d/bbm_bbm_1d_upwind_relaxation.jl - rhs!: 0.0486 ± 0.0006 ms 0.0486 ± 0.00065 ms 0.999 ± 0.018
hyperbolic_serre_green_naghdi_1d/hyperbolic_serre_green_naghdi_dingemans.jl - rhs!: 4.33 ± 0.05 μs 4.39 ± 0.03 μs 0.986 ± 0.013
kdv_1d/kdv_1d_basic.jl - rhs!: 1.42 ± 0.02 μs 1.47 ± 0.011 μs 0.967 ± 0.015
kdv_1d/kdv_1d_implicit.jl - rhs!: 1.41 ± 0.019 μs 1.46 ± 0.03 μs 0.966 ± 0.024
serre_green_naghdi_1d/serre_green_naghdi_well_balanced.jl - rhs!: 0.199 ± 0.0083 ms 0.202 ± 0.0083 ms 0.984 ± 0.058
svaerd_kalisch_1d/svaerd_kalisch_1d_dingemans_relaxation.jl - rhs!: 0.148 ± 0.004 ms 0.147 ± 0.0042 ms 1 ± 0.04
time_to_load 2.18 ± 0.0083 s 2.18 ± 0.011 s 0.996 ± 0.0064
Memory benchmarks
main 858e76f... main / 858e76f...
bbm_1d/bbm_1d_basic.jl - rhs!: 1 allocs: 4.12 kB 1 allocs: 4.12 kB 1
bbm_1d/bbm_1d_fourier.jl - rhs!: 1 allocs: 4.12 kB 1 allocs: 4.12 kB 1
bbm_bbm_1d/bbm_bbm_1d_basic_reflecting.jl - rhs!: 5 allocs: 1.17 kB 5 allocs: 1.17 kB 1
bbm_bbm_1d/bbm_bbm_1d_dg.jl - rhs!: 10 allocs: 8.62 kB 10 allocs: 8.62 kB 1
bbm_bbm_1d/bbm_bbm_1d_relaxation.jl - rhs!: 2 allocs: 8.25 kB 2 allocs: 8.25 kB 1
bbm_bbm_1d/bbm_bbm_1d_upwind_relaxation.jl - rhs!: 2 allocs: 8.25 kB 2 allocs: 8.25 kB 1
hyperbolic_serre_green_naghdi_1d/hyperbolic_serre_green_naghdi_dingemans.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
kdv_1d/kdv_1d_basic.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
kdv_1d/kdv_1d_implicit.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
serre_green_naghdi_1d/serre_green_naghdi_well_balanced.jl - rhs!: 0.075 k allocs: 0.66 MB 0.075 k allocs: 0.66 MB 1
svaerd_kalisch_1d/svaerd_kalisch_1d_dingemans_relaxation.jl - rhs!: 0.042 k allocs: 0.315 MB 0.042 k allocs: 0.315 MB 1
time_to_load 0.153 k allocs: 14.5 kB 0.153 k allocs: 14.5 kB 1

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/callbacks_step/relaxation.jl 50.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@ranocha ranocha merged commit 3f93d4d into main Feb 24, 2026
13 checks passed
@ranocha ranocha deleted the fix-JET branch February 24, 2026 04:34
@ranocha
Copy link
Copy Markdown
Member

ranocha commented Feb 24, 2026

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants