Skip to content

alias_A depending on sparsity #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

alias_A depending on sparsity #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7fbeb8
alias_A depending on sparsity
ranocha Jul 18, 2024
0fd135d
Merge branch 'main' into hr/alias_A
ranocha Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions src/mprk.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,9 @@ function alg_cache(alg::MPE, u, rate_prototype, ::Type{uEltypeNoUnits},
# as well as to store the system matrix of the linear system
# Right hand side of linear system is always uprev
linprob = LinearProblem(P, _vec(uprev))
linsolve = init(linprob, alg.linsolve, alias_A = true, alias_b = true,
linsolve = init(linprob, alg.linsolve;
alias_A = !issparse(P),
alias_b = true,
assumptions = LinearSolve.OperatorAssumptions(true))

MPEConservativeCache(P, σ, tab, linsolve)
Expand All @@ -360,7 +362,9 @@ function alg_cache(alg::MPE, u, rate_prototype, ::Type{uEltypeNoUnits},
# We use P to store the evaluation of the PDS
# as well as to store the system matrix of the linear system
linprob = LinearProblem(P, _vec(linsolve_rhs))
linsolve = init(linprob, alg.linsolve, alias_A = true, alias_b = true,
linsolve = init(linprob, alg.linsolve;
alias_A = !issparse(P),
alias_b = true,
assumptions = LinearSolve.OperatorAssumptions(true))

MPECache(P, similar(u), σ, tab, linsolve_rhs, linsolve)
Expand Down Expand Up @@ -658,15 +662,19 @@ function alg_cache(alg::MPRK22, u, rate_prototype, ::Type{uEltypeNoUnits},
# not be altered, since it is needed to compute the adaptive time step
# size.
linprob = LinearProblem(P2, _vec(tmp))
linsolve = init(linprob, alg.linsolve, alias_A = true, alias_b = true,
linsolve = init(linprob, alg.linsolve;
alias_A = !issparse(P2),
alias_b = true,
assumptions = LinearSolve.OperatorAssumptions(true))

MPRK22ConservativeCache(tmp, P, P2, σ,
tab, #MPRK22ConstantCache
linsolve)
elseif f isa PDSFunction
linprob = LinearProblem(P2, _vec(tmp))
linsolve = init(linprob, alg.linsolve, alias_A = true, alias_b = true,
linsolve = init(linprob, alg.linsolve;
alias_A = !issparse(P2),
alias_b = true,
assumptions = LinearSolve.OperatorAssumptions(true))

MPRK22Cache(tmp, P, P2,
Expand Down Expand Up @@ -1242,7 +1250,9 @@ function alg_cache(alg::Union{MPRK43I, MPRK43II}, u, rate_prototype, ::Type{uElt
# not be altered, since it is needed to compute the adaptive time step
# size.
linprob = LinearProblem(P3, _vec(tmp))
linsolve = init(linprob, alg.linsolve, alias_A = true, alias_b = true,
linsolve = init(linprob, alg.linsolve;
alias_A = !issparse(P3),
alias_b = true,
assumptions = LinearSolve.OperatorAssumptions(true))
MPRK43ConservativeCache(tmp, tmp2, P, P2, P3, σ, tab, linsolve)
elseif f isa PDSFunction
Expand All @@ -1251,7 +1261,9 @@ function alg_cache(alg::Union{MPRK43I, MPRK43II}, u, rate_prototype, ::Type{uElt
D3 = similar(u)

linprob = LinearProblem(P3, _vec(tmp))
linsolve = init(linprob, alg.linsolve, alias_A = true, alias_b = true,
linsolve = init(linprob, alg.linsolve;
alias_A = !issparse(P3),
alias_b = true,
assumptions = LinearSolve.OperatorAssumptions(true))

MPRK43Cache(tmp, tmp2, P, P2, P3, D, D2, D3, σ, tab, linsolve)
Expand Down
16 changes: 12 additions & 4 deletions src/sspmprk.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,15 +240,19 @@ function alg_cache(alg::SSPMPRK22, u, rate_prototype, ::Type{uEltypeNoUnits},

if f isa ConservativePDSFunction
linprob = LinearProblem(P2, _vec(tmp))
linsolve = init(linprob, alg.linsolve, alias_A = true, alias_b = true,
linsolve = init(linprob, alg.linsolve;
alias_A = !issparse(P2),
alias_b = true,
assumptions = LinearSolve.OperatorAssumptions(true))

SSPMPRK22ConservativeCache(tmp, P, P2, σ,
tab, #MPRK22ConstantCache
linsolve)
elseif f isa PDSFunction
linprob = LinearProblem(P2, _vec(tmp))
linsolve = init(linprob, alg.linsolve, alias_A = true, alias_b = true,
linsolve = init(linprob, alg.linsolve;
alias_A = !issparse(P2),
alias_b = true,
assumptions = LinearSolve.OperatorAssumptions(true))

SSPMPRK22Cache(tmp, P, P2,
Expand Down Expand Up @@ -756,7 +760,9 @@ function alg_cache(alg::SSPMPRK43, u, rate_prototype, ::Type{uEltypeNoUnits},

if f isa ConservativePDSFunction
linprob = LinearProblem(P3, _vec(tmp))
linsolve = init(linprob, alg.linsolve, alias_A = true, alias_b = true,
linsolve = init(linprob, alg.linsolve;
alias_A = !issparse(P3),
alias_b = true,
assumptions = LinearSolve.OperatorAssumptions(true))
SSPMPRK43ConservativeCache(tmp, tmp2, P, P2, P3, σ, ρ, tab, linsolve)
elseif f isa PDSFunction
Expand All @@ -765,7 +771,9 @@ function alg_cache(alg::SSPMPRK43, u, rate_prototype, ::Type{uEltypeNoUnits},
D3 = similar(u)

linprob = LinearProblem(P3, _vec(tmp))
linsolve = init(linprob, alg.linsolve, alias_A = true, alias_b = true,
linsolve = init(linprob, alg.linsolve;
alias_A = !issparse(P3),
alias_b = true,
assumptions = LinearSolve.OperatorAssumptions(true))

SSPMPRK43Cache(tmp, tmp2, P, P2, P3, D, D2, D3, σ, ρ, tab, linsolve)
Expand Down