Support executables on path taking priority over repo executables#2
Open
CetaceanNation wants to merge 1 commit intoNyanSatan:masterfrom
Open
Support executables on path taking priority over repo executables#2CetaceanNation wants to merge 1 commit intoNyanSatan:masterfrom
CetaceanNation wants to merge 1 commit intoNyanSatan:masterfrom
Conversation
Owner
|
I agree that there should be a way to override/supply the embedded executables, but the embedded ones should still take precedence by default |
CetaceanNation
force-pushed
the
master
branch
from
d5e893c to
56697fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes use on other platforms simpler. Rather than having to make links (or copies) in the executables directory, this is a change to lookup the binaries utilized in the script via shutil first, then fallback to the executables provided in the repo if not found.
Could be undesirable if it's possible executable versions exist which do not support the functionality expected by this script, but I'm inclined to believe that's not the case.