Open
Conversation
- This will help seeing the current data in database - The javascript file is required to fix ActiveAdmin error refs TICKET_12345
refs TICKET_12345
…nd personal computer setup. refs TICKET_12345
This migration will also change historical data to align it with new changes. refs TICKET_12345
When a new orderProduct is created, the current product price will be store on the OrderProduct to allow future changes to product price without impacting historical orders. refs TICKET_12345
refs TICKET_12345
refs TICKET_12345
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The proposed fix for this task is to add a new price column to the OrderProduct table because:
There is a small line commented out to prevent editing of the newly added each_item_price_in_cents column. This line can be uncommented once the code has been deployed. This decision is based on the assumption that once an item is sold, its price should remain unchanged. If this column were editable, I would use the paper_trail gem to track who makes changes to this column for compliance purposes.
Thank you for the opportunity. It has been a nice, small challenge.