Fix isPositionClear force loading chunks exponentially#12
Open
RequiDev wants to merge 1 commit intoNyfaria:1.20.xfrom
Open
Fix isPositionClear force loading chunks exponentially#12RequiDev wants to merge 1 commit intoNyfaria:1.20.xfrom
RequiDev wants to merge 1 commit intoNyfaria:1.20.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not 100% sure about this line of code, but to me it very much seems like, it's checking non-loaded chunks for position checks, which forces those chunks to load (can be observed with spark having loaded 7000 chunks when just sitting at spawn in single-player with a bunch of spiders).
At least when testing, the spiders still move as they're supposed to and the previously observed lag is gone.
Other versions may also be affected.